diff mbox

[dpdk-dev] ipc: fix duplicate string copy

Message ID e4d2b6acfa50621874bdb92c3c8db9f97156754e.1525343708.git.anatoly.burakov@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Anatoly Burakov May 3, 2018, 10:35 a.m. UTC 
  Coverity issue: 272582

Fixes: 2147c0950580 ("ipc: clean up code")
Cc: jianfeng.tan@intel.com

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_eal/common/eal_common_proc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Van Haaren, Harry May 9, 2018, 1:58 p.m. UTC | #1 
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Anatoly Burakov
> Sent: Thursday, May 3, 2018 11:35 AM
> To: dev@dpdk.org
> Cc: Tan, Jianfeng <jianfeng.tan@intel.com>
> Subject: [dpdk-dev] [PATCH] ipc: fix duplicate string copy
> 
> Coverity issue: 272582
> 
> Fixes: 2147c0950580 ("ipc: clean up code")
> Cc: jianfeng.tan@intel.com
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Thomas Monjalon May 14, 2018, 1:21 a.m. UTC | #2 
> > Coverity issue: 272582
> > 
> > Fixes: 2147c0950580 ("ipc: clean up code")
> > Cc: jianfeng.tan@intel.com
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index 611aba2..707d8ab 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -870,7 +870,6 @@  mp_request_async(const char *dst, struct rte_mp_msg *req,
 
 	pending_req->type = REQUEST_TYPE_ASYNC;
 	strlcpy(pending_req->dst, dst, sizeof(pending_req->dst));
-	strcpy(pending_req->dst, dst);
 	pending_req->request = req;
 	pending_req->reply = reply_msg;
 	pending_req->async.param = param;