diff mbox

[dpdk-dev,v1] doc: add mlx4 CRC stripping toggling limitation

Message ID 1525782629-897-1-git-send-email-ophirmu@mellanox.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ophir Munk May 8, 2018, 12:30 p.m. UTC 
  Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
 doc/guides/nics/mlx4.rst | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Thomas Monjalon May 8, 2018, 12:34 p.m. UTC | #1 
08/05/2018 14:30, Ophir Munk:
> +Limitations
> +-----------
> +
> +- CRC stripping is supported by default and this capability is always reported
> +  as "true". The ability to enable/disable CRC stripping requires OFED version
> +  4.3-1.5.0.0 or rdma-core version v18.

I think it is better to merge this patch with the one fixing the capability.
So we will be able to refer to one atomic commit in the history.
Shahaf Shuler May 9, 2018, 10:07 a.m. UTC | #2 
Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon:
> Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
> 
> 08/05/2018 14:30, Ophir Munk:
> > +Limitations
> > +-----------
> > +
> > +- CRC stripping is supported by default and this capability is always
> reported
> > +  as "true". The ability to enable/disable CRC stripping requires OFED
> version
> > +  4.3-1.5.0.0 or rdma-core version v18.
> 
> I think it is better to merge this patch with the one fixing the capability.
> So we will be able to refer to one atomic commit in the history.
> 

If you agree Ophir I will squash the two patch into one and merge it on mlx4.  OK?
Ophir Munk May 9, 2018, 10:31 a.m. UTC | #3 
Sure. Agreed.

Regards,
Ophir

> -----Original Message-----
> From: Shahaf Shuler
> Sent: Wednesday, May 09, 2018 1:07 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Ophir Munk
> <ophirmu@mellanox.com>
> Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Olga
> Shern <olgas@mellanox.com>
> Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
> 
> Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon:
> > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
> >
> > 08/05/2018 14:30, Ophir Munk:
> > > +Limitations
> > > +-----------
> > > +
> > > +- CRC stripping is supported by default and this capability is always
> > reported
> > > +  as "true". The ability to enable/disable CRC stripping requires OFED
> > version
> > > +  4.3-1.5.0.0 or rdma-core version v18.
> >
> > I think it is better to merge this patch with the one fixing the capability.
> > So we will be able to refer to one atomic commit in the history.
> >
> 
> If you agree Ophir I will squash the two patch into one and merge it on mlx4.
> OK?
Shahaf Shuler May 9, 2018, 11:12 a.m. UTC | #4 
Wednesday, May 9, 2018 1:32 PM, Ophir Munk:
> Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation
> 
> Sure. Agreed.
> 
> Regards,
> Ophir
> 
> > -----Original Message-----
> > From: Shahaf Shuler
> > Sent: Wednesday, May 09, 2018 1:07 PM
> > To: Thomas Monjalon <thomas@monjalon.net>; Ophir Munk
> > <ophirmu@mellanox.com>
> > Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Olga
> > Shern <olgas@mellanox.com>
> > Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling
> > limitation
> >
> > Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon:
> > > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling
> > > limitation

Applied to next-net-mlx along and squashed into 
http://dpdk.org/dev/patchwork/patch/39461/


> > >
> > > 08/05/2018 14:30, Ophir Munk:
> > > > +Limitations
> > > > +-----------
> > > > +
> > > > +- CRC stripping is supported by default and this capability is
> > > > +always
> > > reported
> > > > +  as "true". The ability to enable/disable CRC stripping requires
> > > > + OFED
> > > version
> > > > +  4.3-1.5.0.0 or rdma-core version v18.
> > >
> > > I think it is better to merge this patch with the one fixing the capability.
> > > So we will be able to refer to one atomic commit in the history.
> > >
> >
> > If you agree Ophir I will squash the two patch into one and merge it on
> mlx4.
> > OK?
diff mbox

Patch

diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
index 9564f89..a6bbde8 100644
--- a/doc/guides/nics/mlx4.rst
+++ b/doc/guides/nics/mlx4.rst
@@ -143,6 +143,13 @@  below.
     following limitation: VLAN filtering is not supported with this mode.
     This is the recommended mode in case VLAN filter is not needed.
 
+Limitations
+-----------
+
+- CRC stripping is supported by default and this capability is always reported
+  as "true". The ability to enable/disable CRC stripping requires OFED version
+  4.3-1.5.0.0 or rdma-core version v18.
+
 Prerequisites
 -------------