[dpdk-dev,v2] net/i40e: fix missing VLAN offload capability

Message ID 20180510065038.4011-1-yanglong.wu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yanglong Wu May 10, 2018, 6:50 a.m. UTC
  VLAN offload capability should be exposed in VF
since i40e does support it.

Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
---
v2:
rework as comments required
---
 drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Qi Zhang May 11, 2018, 1:35 a.m. UTC | #1
Hi Yanglong
	The patch is OK, could you rebase to dpdk-next-net ? 
Thanks
Qi

> -----Original Message-----
> From: Wu, Yanglong
> Sent: Thursday, May 10, 2018 2:51 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Wu,
> Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH v2] net/i40e: fix missing VLAN offload capability
> 
> VLAN offload capability should be exposed in VF since i40e does support it.
> 
> Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> v2:
> rework as comments required
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index b9dea2e5b..2a37b31b2 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>  		DEV_RX_OFFLOAD_TCP_CKSUM |
>  		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
>  		DEV_RX_OFFLOAD_CRC_STRIP |
> -		DEV_RX_OFFLOAD_SCATTER;
> +		DEV_RX_OFFLOAD_SCATTER |
> +		DEV_RX_OFFLOAD_VLAN_FILTER;
> 
>  	dev_info->tx_queue_offload_capa = 0;
>  	dev_info->tx_offload_capa =
> --
> 2.11.0
  
Ferruh Yigit May 11, 2018, 1:53 a.m. UTC | #2
On 5/11/2018 2:35 AM, Zhang, Qi Z wrote:
> Hi Yanglong
> 	The patch is OK, could you rebase to dpdk-next-net ? 
> Thanks
> Qi
> 
>> -----Original Message-----
>> From: Wu, Yanglong
>> Sent: Thursday, May 10, 2018 2:51 PM
>> To: dev@dpdk.org
>> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Dai, Wei <wei.dai@intel.com>; Wu,
>> Yanglong <yanglong.wu@intel.com>
>> Subject: [PATCH v2] net/i40e: fix missing VLAN offload capability
>>
>> VLAN offload capability should be exposed in VF since i40e does support it.
>>
>> Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
>> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index b9dea2e5b..2a37b31b2 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2200,7 +2200,8 @@  i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
-		DEV_RX_OFFLOAD_SCATTER;
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_VLAN_FILTER;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =