diff mbox

[dpdk-dev] net/vhost: do not zero ol_flags in eth_vhost_rx()

Message ID 20180510070414.8517-1-tiwei.bie@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tiwei Bie May 10, 2018, 7:04 a.m. UTC 
  The ol_flags of mbufs returned by rte_vhost_dequeue_burst()
contain necessary offload information. It can't be zeroed.

Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
Cc: Jan Blunck <jblunck@infradead.org>
Cc: stable@dpdk.org

Reported-by: Lei Yao <lei.a.yao@intel.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 drivers/net/vhost/rte_eth_vhost.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Maxime Coquelin May 16, 2018, 10:55 a.m. UTC | #1 
On 05/10/2018 09:04 AM, Tiwei Bie wrote:
> The ol_flags of mbufs returned by rte_vhost_dequeue_burst()
> contain necessary offload information. It can't be zeroed.
> 
> Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
> Cc: Jan Blunck<jblunck@infradead.org>
> Cc:stable@dpdk.org
> 
> Reported-by: Lei Yao<lei.a.yao@intel.com>
> Signed-off-by: Tiwei Bie<tiwei.bie@intel.com>
> ---
>   drivers/net/vhost/rte_eth_vhost.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Maxime Coquelin May 16, 2018, 2:36 p.m. UTC | #2 
On 05/16/2018 12:55 PM, Maxime Coquelin wrote:
> 
> 
> On 05/10/2018 09:04 AM, Tiwei Bie wrote:
>> The ol_flags of mbufs returned by rte_vhost_dequeue_burst()
>> contain necessary offload information. It can't be zeroed.
>>
>> Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
>> Cc: Jan Blunck<jblunck@infradead.org>
>> Cc:stable@dpdk.org
>>
>> Reported-by: Lei Yao<lei.a.yao@intel.com>
>> Signed-off-by: Tiwei Bie<tiwei.bie@intel.com>
>> ---
>>   drivers/net/vhost/rte_eth_vhost.c | 1 -
>>   1 file changed, 1 deletion(-)
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio/master with commit message reworded to:

net/vhost: do not clear offload flags in Rx

> Thanks,
> Maxime
diff mbox

Patch

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index ff5424a92..47fd23eb3 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -400,7 +400,6 @@  eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 
 	for (i = 0; likely(i < nb_rx); i++) {
 		bufs[i]->port = r->port;
-		bufs[i]->ol_flags = 0;
 		bufs[i]->vlan_tci = 0;
 
 		if (r->internal->vlan_strip)