diff mbox

[dpdk-dev,v1] net/failsafe: add an RSS hash update callback

Message ID 1525963090-17097-1-git-send-email-ophirmu@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ophir Munk May 10, 2018, 2:38 p.m. UTC 
  Add an RSS hash update callback to eth_dev_ops.

Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
 drivers/net/failsafe/failsafe_ops.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Gaëtan Rivet May 11, 2018, 8:31 a.m. UTC | #1 
Hi Ophir,

On Thu, May 10, 2018 at 02:38:10PM +0000, Ophir Munk wrote:
> Add an RSS hash update callback to eth_dev_ops.
> 
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>

Thank you for submitting this, the patch is clean.

Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

> ---
>  drivers/net/failsafe/failsafe_ops.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
> index 089f114..d04277b 100644
> --- a/drivers/net/failsafe/failsafe_ops.c
> +++ b/drivers/net/failsafe/failsafe_ops.c
> @@ -13,6 +13,7 @@
>  #include <rte_malloc.h>
>  #include <rte_flow.h>
>  #include <rte_cycles.h>
> +#include <rte_ethdev.h>
>  
>  #include "failsafe_private.h"
>  
> @@ -947,6 +948,31 @@ fs_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
>  }
>  
>  static int
> +fs_rss_hash_update(struct rte_eth_dev *dev,
> +			struct rte_eth_rss_conf *rss_conf)
> +{
> +	struct sub_device *sdev;
> +	uint8_t i;
> +	int ret;
> +
> +	fs_lock(dev, 0);
> +	FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {
> +		ret = rte_eth_dev_rss_hash_update(PORT_ID(sdev), rss_conf);
> +		ret = fs_err(sdev, ret);
> +		if (ret) {
> +			ERROR("Operation rte_eth_dev_rss_hash_update"
> +				" failed for sub_device %d with error %d",
> +				i, ret);
> +			fs_unlock(dev, 0);
> +			return ret;
> +		}
> +	}
> +	fs_unlock(dev, 0);
> +
> +	return 0;
> +}
> +
> +static int
>  fs_filter_ctrl(struct rte_eth_dev *dev,
>  		enum rte_filter_type type,
>  		enum rte_filter_op op,
> @@ -1005,5 +1031,6 @@ const struct eth_dev_ops failsafe_ops = {
>  	.mac_addr_remove = fs_mac_addr_remove,
>  	.mac_addr_add = fs_mac_addr_add,
>  	.mac_addr_set = fs_mac_addr_set,
> +	.rss_hash_update = fs_rss_hash_update,
>  	.filter_ctrl = fs_filter_ctrl,
>  };
> -- 
> 2.7.4
>
Ferruh Yigit May 11, 2018, 4:18 p.m. UTC | #2 
On 5/11/2018 9:31 AM, Gaëtan Rivet wrote:
> Hi Ophir,
> 
> On Thu, May 10, 2018 at 02:38:10PM +0000, Ophir Munk wrote:
>> Add an RSS hash update callback to eth_dev_ops.
>>
>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> 
> Thank you for submitting this, the patch is clean.
> 
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index 089f114..d04277b 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -13,6 +13,7 @@ 
 #include <rte_malloc.h>
 #include <rte_flow.h>
 #include <rte_cycles.h>
+#include <rte_ethdev.h>
 
 #include "failsafe_private.h"
 
@@ -947,6 +948,31 @@  fs_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
 }
 
 static int
+fs_rss_hash_update(struct rte_eth_dev *dev,
+			struct rte_eth_rss_conf *rss_conf)
+{
+	struct sub_device *sdev;
+	uint8_t i;
+	int ret;
+
+	fs_lock(dev, 0);
+	FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {
+		ret = rte_eth_dev_rss_hash_update(PORT_ID(sdev), rss_conf);
+		ret = fs_err(sdev, ret);
+		if (ret) {
+			ERROR("Operation rte_eth_dev_rss_hash_update"
+				" failed for sub_device %d with error %d",
+				i, ret);
+			fs_unlock(dev, 0);
+			return ret;
+		}
+	}
+	fs_unlock(dev, 0);
+
+	return 0;
+}
+
+static int
 fs_filter_ctrl(struct rte_eth_dev *dev,
 		enum rte_filter_type type,
 		enum rte_filter_op op,
@@ -1005,5 +1031,6 @@  const struct eth_dev_ops failsafe_ops = {
 	.mac_addr_remove = fs_mac_addr_remove,
 	.mac_addr_add = fs_mac_addr_add,
 	.mac_addr_set = fs_mac_addr_set,
+	.rss_hash_update = fs_rss_hash_update,
 	.filter_ctrl = fs_filter_ctrl,
 };