diff mbox

[dpdk-dev,v2] net/tap: add RSS hash update callback

Message ID 1525973425-28889-1-git-send-email-ophirmu@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ophir Munk May 10, 2018, 5:30 p.m. UTC 
  Add RSS hash update callback to eth_dev_ops.

Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
v1:
Initial release
v2:
typo fix

 drivers/net/tap/rte_eth_tap.c | 39 ++++++++++++++++++++++++++++++++++++---
 drivers/net/tap/tap_rss.h     |  3 +++
 2 files changed, 39 insertions(+), 3 deletions(-)

Comments

Wiles, Keith May 15, 2018, 12:21 p.m. UTC | #1 
> On May 10, 2018, at 12:30 PM, Ophir Munk <ophirmu@mellanox.com> wrote:
> 
> Add RSS hash update callback to eth_dev_ops.
> 
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
> v1:
> Initial release
> v2:
> typo fix
> 

Acked by: Keith Wiles<keith.wiles@intel.com>

Regards,
Keith
Ferruh Yigit May 17, 2018, 5:11 p.m. UTC | #2 
On 5/15/2018 1:21 PM, Wiles, Keith wrote:
> 
> 
>> On May 10, 2018, at 12:30 PM, Ophir Munk <ophirmu@mellanox.com> wrote:
>>
>> Add RSS hash update callback to eth_dev_ops.
>>
>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
>> ---
>> v1:
>> Initial release
>> v2:
>> typo fix
>>
> 
> Acked by: Keith Wiles<keith.wiles@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 09cd70c..8556c6c 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -835,11 +835,10 @@  tap_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 				    dev_info->tx_queue_offload_capa;
 	dev_info->hash_key_size = TAP_RSS_HASH_KEY_SIZE;
 	/*
-	 * limitation: TAP suppors all of the following hash
+	 * limitation: TAP supports all of IP, UDP and TCP hash
 	 * functions together and not in partial combinations
 	 */
-	dev_info->flow_type_rss_offloads =
-		ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP;
+	dev_info->flow_type_rss_offloads = ~TAP_RSS_HF_MASK;
 }
 
 static int
@@ -1434,6 +1433,39 @@  tap_flow_ctrl_set(struct rte_eth_dev *dev __rte_unused,
 	return 0;
 }
 
+/**
+ * DPDK callback to update the RSS hash configuration.
+ *
+ * @param dev
+ *   Pointer to Ethernet device structure.
+ * @param[in] rss_conf
+ *   RSS configuration data.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+tap_rss_hash_update(struct rte_eth_dev *dev,
+		struct rte_eth_rss_conf *rss_conf)
+{
+	if (rss_conf->rss_hf & TAP_RSS_HF_MASK) {
+		rte_errno = EINVAL;
+		return -rte_errno;
+	}
+	if (rss_conf->rss_key && rss_conf->rss_key_len) {
+		/*
+		 * Currently TAP RSS key is hard coded
+		 * and cannot be updated
+		 */
+		TAP_LOG(ERR,
+			"port %u RSS key cannot be updated",
+			dev->data->port_id);
+		rte_errno = EINVAL;
+		return -rte_errno;
+	}
+	return 0;
+}
+
 static const struct eth_dev_ops ops = {
 	.dev_start              = tap_dev_start,
 	.dev_stop               = tap_dev_stop,
@@ -1459,6 +1491,7 @@  static const struct eth_dev_ops ops = {
 	.stats_get              = tap_stats_get,
 	.stats_reset            = tap_stats_reset,
 	.dev_supported_ptypes_get = tap_dev_supported_ptypes_get,
+	.rss_hash_update        = tap_rss_hash_update,
 	.filter_ctrl            = tap_dev_filter_ctrl,
 };
 
diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h
index bd6b97b..17606b2 100644
--- a/drivers/net/tap/tap_rss.h
+++ b/drivers/net/tap/tap_rss.h
@@ -12,6 +12,9 @@ 
 /* Fixed RSS hash key size in bytes. */
 #define TAP_RSS_HASH_KEY_SIZE 40
 
+/* Supported RSS */
+#define TAP_RSS_HF_MASK (~(ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP))
+
 /* hashed fields for RSS */
 enum hash_field {
 	HASH_FIELD_IPV4_L3,	/* IPv4 src/dst addr */