[dpdk-dev,v4,22/23] rte_ip.h: cast return checksum size to uint16

Message ID 152627467823.53156.8832807627543580935.stgit@localhost.localdomain (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andy Green May 14, 2018, 5:11 a.m. UTC
  In file included from ./dpdk/worker.c:94:
/projects/lagopus/src/dpdk/build/include/rte_ip.h:
332:9: warning: conversion from 'uint32_t'
{aka 'unsigned int'} to 'uint16_t' {aka 'short
unsigned int'} may change value [-Wconversion]
  return cksum;
         ^~~~~

/projects/lagopus/src/dpdk/build/include/rte_ip.h:
In function 'rte_ipv6_udptcp_cksum':
/projects/lagopus/src/dpdk/build/include/rte_ip.h:421:9:
warning: conversion from 'uint32_t' {aka 'unsigned int'}
to 'uint16_t' {aka 'short unsigned int'} may change
value [-Wconversion]
  return cksum;
         ^~~~~


Signed-off-by: Andy Green <andy@warmcat.com>
---
 lib/librte_net/rte_ip.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Patch

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 88dfbaa9a..c46398548 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -329,7 +329,7 @@  rte_ipv4_udptcp_cksum(const struct ipv4_hdr *ipv4_hdr, const void *l4_hdr)
 	if (cksum == 0)
 		cksum = 0xffff;
 
-	return cksum;
+	return (uint16_t)cksum;
 }
 
 /**
@@ -418,7 +418,7 @@  rte_ipv6_udptcp_cksum(const struct ipv6_hdr *ipv6_hdr, const void *l4_hdr)
 	if (cksum == 0)
 		cksum = 0xffff;
 
-	return cksum;
+	return (uint16_t)cksum;
 }
 
 #ifdef __cplusplus