[dpdk-dev] test: fix build with icc

Message ID 1526280622-50931-1-git-send-email-abhinandan.gujjar@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Gujjar, Abhinandan S May 14, 2018, 6:50 a.m. UTC
  This patch provides fix for icc compilation issue with event
crypto adapter test application.
Currently, number of elements in the session mempool is defined
by max_nb_sessions & this is replaced with a macro.

Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test")

Reported-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
---
 test/test/test_event_crypto_adapter.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

De Lara Guarch, Pablo May 14, 2018, 8:13 a.m. UTC | #1
> -----Original Message-----
> From: Gujjar, Abhinandan S
> Sent: Monday, May 14, 2018 7:50 AM
> To: jerin.jacob@caviumnetworks.com; thomas@monjalon.net; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Gujjar,
> Abhinandan S <abhinandan.gujjar@intel.com>
> Subject: [PATCH] test: fix build with icc
> 
> This patch provides fix for icc compilation issue with event crypto adapter test
> application.
> Currently, number of elements in the session mempool is defined by
> max_nb_sessions & this is replaced with a macro.
> 
> Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test")
> 
> Reported-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
  
Thomas Monjalon May 14, 2018, 9:21 a.m. UTC | #2
> > This patch provides fix for icc compilation issue with event crypto adapter test
> > application.
> > Currently, number of elements in the session mempool is defined by
> > max_nb_sessions & this is replaced with a macro.
> > 
> > Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test")
> > 
> > Reported-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks
  

Patch

diff --git a/test/test/test_event_crypto_adapter.c b/test/test/test_event_crypto_adapter.c
index 17eae5d..6f0e794 100644
--- a/test/test/test_event_crypto_adapter.c
+++ b/test/test/test_event_crypto_adapter.c
@@ -21,6 +21,7 @@ 
 #define MBUF_CACHE_SIZE           (256)
 #define MAXIMUM_IV_LENGTH         (16)
 #define DEFAULT_NUM_OPS_INFLIGHT  (128)
+#define MAX_NB_SESSIONS            4
 #define TEST_APP_PORT_ID           0
 #define TEST_APP_EV_QUEUE_ID       0
 #define TEST_APP_EV_PRIORITY       0
@@ -527,7 +528,7 @@  struct rte_event_crypto_request request_info = {
 
 	params.session_mpool = rte_mempool_create(
 				"CRYPTO_ADAPTER_SESSION_MP",
-				info.sym.max_nb_sessions * 2,
+				MAX_NB_SESSIONS * 2,
 				session_size,
 				0, 0, NULL, NULL, NULL,
 				NULL, SOCKET_ID_ANY,