[dpdk-dev] eal/service: improve error checking of coremasks
Checks
Commit Message
This commit improves the error checking performed on the
core masks (or lists) of the service cores, in particular
with respect to the data-plane (RTE) cores of DPDK.
With this commit, invalid configurations are detected at
runtime, and warning messages are printed to inform the user.
For example specifying the coremask as 0xf, and the service
coremask as 0xff00 is invalid as not all service-cores are
contained within the coremask. A warning is now printed to
inform the user.
Reported-by: Vipin Varghese <vipin.varghese@intel.com>
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Cc: thomas@monjalon.net
Cc: vipin.varghese@intel.com
@Thomas, please consider this patch for RC4, it adds checks
and prints warnings, better usability, no functional changes.
---
lib/librte_eal/common/eal_common_options.c | 39 ++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
Comments
15/05/2018 16:52, Harry van Haaren:
> + if (eal_service_cores_parsed())
> + RTE_LOG(ERR, EAL,
> + "Warning: Service cores parsed before dataplane cores. Ensure -c is before -s or -S.\n");
> +
[...]
> + if (core_parsed && taken_lcore_count != count) {
> + RTE_LOG(ERR, EAL,
> + "Warning: not all service cores were in the coremask - ensure -c or -l includes service cores\n");
> + }
Sometimes, messages are split with a dot, sometimes with a dash.
Please choose only one for consistency (I prefer dot).
I think you can split the string and wrap the line at the end of the sentence.
@@ -315,6 +315,7 @@ eal_parse_service_coremask(const char *coremask)
unsigned int count = 0;
char c;
int val;
+ uint32_t taken_lcore_count = 0;
if (coremask == NULL)
return -1;
@@ -358,6 +359,10 @@ eal_parse_service_coremask(const char *coremask)
"lcore %u unavailable\n", idx);
return -1;
}
+
+ if (cfg->lcore_role[idx] == ROLE_RTE)
+ taken_lcore_count++;
+
lcore_config[idx].core_role = ROLE_SERVICE;
count++;
}
@@ -374,11 +379,27 @@ eal_parse_service_coremask(const char *coremask)
if (count == 0)
return -1;
+ if (core_parsed && taken_lcore_count != count) {
+ RTE_LOG(ERR, EAL,
+ "Warning: not all service cores were in the coremask - ensure -c or -l includes service cores\n");
+ }
+
cfg->service_lcore_count = count;
return 0;
}
static int
+eal_service_cores_parsed(void)
+{
+ int idx;
+ for (idx = 0; idx < RTE_MAX_LCORE; idx++) {
+ if (lcore_config[idx].core_role == ROLE_SERVICE)
+ return 1;
+ }
+ return 0;
+}
+
+static int
eal_parse_coremask(const char *coremask)
{
struct rte_config *cfg = rte_eal_get_configuration();
@@ -387,6 +408,10 @@ eal_parse_coremask(const char *coremask)
char c;
int val;
+ if (eal_service_cores_parsed())
+ RTE_LOG(ERR, EAL,
+ "Warning: Service cores parsed before dataplane cores. Ensure -c is before -s or -S.\n");
+
if (coremask == NULL)
return -1;
/* Remove all blank characters ahead and after .
@@ -418,6 +443,7 @@ eal_parse_coremask(const char *coremask)
"unavailable\n", idx);
return -1;
}
+
cfg->lcore_role[idx] = ROLE_RTE;
lcore_config[idx].core_index = count;
count++;
@@ -449,6 +475,7 @@ eal_parse_service_corelist(const char *corelist)
unsigned count = 0;
char *end = NULL;
int min, max;
+ uint32_t taken_lcore_count = 0;
if (corelist == NULL)
return -1;
@@ -490,6 +517,9 @@ eal_parse_service_corelist(const char *corelist)
idx);
return -1;
}
+ if (cfg->lcore_role[idx] == ROLE_RTE)
+ taken_lcore_count++;
+
lcore_config[idx].core_role =
ROLE_SERVICE;
count++;
@@ -504,6 +534,11 @@ eal_parse_service_corelist(const char *corelist)
if (count == 0)
return -1;
+ if (core_parsed && taken_lcore_count != count) {
+ RTE_LOG(ERR, EAL,
+ "Warning: not all service cores were in the coremask - ensure -c or -l includes service cores\n");
+ }
+
return 0;
}
@@ -516,6 +551,10 @@ eal_parse_corelist(const char *corelist)
char *end = NULL;
int min, max;
+ if (eal_service_cores_parsed())
+ RTE_LOG(ERR, EAL,
+ "Warning: Service cores parsed before dataplane cores. Ensure -l is before -s or -S.\n");
+
if (corelist == NULL)
return -1;