diff mbox

[dpdk-dev] bus/vdev: don't double space log messages

Message ID 20180516215140.21134-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger May 16, 2018, 9:51 p.m. UTC 
  The VDEV_LOG() macro already adds a newline, don't duplicate.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/bus/vdev/vdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Ferruh Yigit May 17, 2018, 9:33 a.m. UTC | #1 
On 5/16/2018 10:51 PM, Stephen Hemminger wrote:
> The VDEV_LOG() macro already adds a newline, don't duplicate.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Fixes: d22fcb225c24 ("bus/vdev: change log type")

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon May 20, 2018, 11:20 p.m. UTC | #2 
17/05/2018 11:33, Ferruh Yigit:
> On 5/16/2018 10:51 PM, Stephen Hemminger wrote:
> > The VDEV_LOG() macro already adds a newline, don't duplicate.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Fixes: d22fcb225c24 ("bus/vdev: change log type")
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 9f576eb80f26..099b9ff85a70 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -142,7 +142,7 @@  vdev_probe_all_drivers(struct rte_vdev_device *dev)
 
 	name = rte_vdev_device_name(dev);
 
-	VDEV_LOG(DEBUG, "Search driver %s to probe device %s\n", name,
+	VDEV_LOG(DEBUG, "Search driver %s to probe device %s", name,
 		rte_vdev_device_name(dev));
 
 	if (vdev_parse(name, &driver))
@@ -255,7 +255,7 @@  rte_vdev_init(const char *name, const char *args)
 		ret = vdev_probe_all_drivers(dev);
 		if (ret) {
 			if (ret > 0)
-				VDEV_LOG(ERR, "no driver found for %s\n", name);
+				VDEV_LOG(ERR, "no driver found for %s", name);
 			/* If fails, remove it from vdev list */
 			devargs = dev->device.devargs;
 			TAILQ_REMOVE(&vdev_device_list, dev, next);
@@ -274,7 +274,7 @@  vdev_remove_driver(struct rte_vdev_device *dev)
 	const struct rte_vdev_driver *driver;
 
 	if (!dev->device.driver) {
-		VDEV_LOG(DEBUG, "no driver attach to device %s\n", name);
+		VDEV_LOG(DEBUG, "no driver attach to device %s", name);
 		return 1;
 	}
 
@@ -482,7 +482,7 @@  vdev_probe(void)
 			continue;
 
 		if (vdev_probe_all_drivers(dev)) {
-			VDEV_LOG(ERR, "failed to initialize %s device\n",
+			VDEV_LOG(ERR, "failed to initialize %s device",
 				rte_vdev_device_name(dev));
 			ret = -1;
 		}