diff mbox

[dpdk-dev] net/i40e: fix link up failure issue

Message ID 1526609118-119241-1-git-send-email-jia.guo@intel.com (mailing list archive)
State Rejected, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Guo, Jia May 18, 2018, 2:05 a.m. UTC 
  In case of the known issue, that DPDK PHY config can't synchronous with
kernel driver and firmware, this will result of the nic can't link up
after rebind to the kernel driver. This patch propose to work around it
by don't config PHY and don't set link down when stop device.

Fixes: 6e145fcc754b ("i40e: support autoneg or force link speed")

Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
v2->v1:
delete irrelevent part of code
---
 drivers/net/i40e/i40e_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Qi Zhang May 18, 2018, 2:56 a.m. UTC | #1 
> -----Original Message-----
> From: Guo, Jia
> Sent: Friday, May 18, 2018 10:05 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Subject: [PATCH] net/i40e: fix link up failure issue
> 
> In case of the known issue, that DPDK PHY config can't synchronous with
> kernel driver and firmware, this will result of the nic can't link up after rebind
> to the kernel driver. This patch propose to work around it by don't config PHY
> and don't set link down when stop device.
> 
> Fixes: 6e145fcc754b ("i40e: support autoneg or force link speed")
> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Qi Zhang May 18, 2018, 1:16 p.m. UTC | #2 
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Friday, May 18, 2018 10:57 AM
> To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/i40e: fix link up failure issue
> 
> > -----Original Message-----
> > From: Guo, Jia
> > Sent: Friday, May 18, 2018 10:05 AM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> > Subject: [PATCH] net/i40e: fix link up failure issue
> >
> > In case of the known issue, that DPDK PHY config can't synchronous
> > with kernel driver and firmware, this will result of the nic can't
> > link up after rebind to the kernel driver. This patch propose to work
> > around it by don't config PHY and don't set link down when stop device.
> >
> > Fixes: 6e145fcc754b ("i40e: support autoneg or force link speed")
> >
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Author agree to withdraw the patch, since kernel fix is in plan also this may impact link down experience, so

Nacked-by: Qi Zhang <qi.z.zhang@intel.com>
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 014bfce..27a5722 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2306,9 +2306,6 @@  i40e_dev_stop(struct rte_eth_dev *dev)
 	/* Clear all queues and release memory */
 	i40e_dev_clear_queues(dev);
 
-	/* Set link down */
-	i40e_dev_set_link_down(dev);
-
 	if (!rte_intr_allow_others(intr_handle))
 		/* resume to the default handler */
 		rte_intr_callback_register(intr_handle,