diff mbox

[dpdk-dev] lib/crypto: clarify when it's ok to clear private session data

Message ID 1526985411-17739-1-git-send-email-fiona.trahe@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Fiona Trahe May 22, 2018, 10:36 a.m. UTC 
  Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 lib/librte_cryptodev/rte_cryptodev.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Comments

De Lara Guarch, Pablo May 22, 2018, 11:07 a.m. UTC | #1 
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, May 22, 2018 11:37 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] lib/crypto: clarify when it's ok to clear private session data
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
De Lara Guarch, Pablo May 22, 2018, 12:44 p.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Tuesday, May 22, 2018 12:08 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: akhil.goyal@nxp.com
> Subject: Re: [dpdk-dev] [PATCH] lib/crypto: clarify when it's ok to clear private
> session data
> 
> 
> 
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Tuesday, May 22, 2018 11:37 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe,
> > Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> > Subject: [PATCH] lib/crypto: clarify when it's ok to clear private
> > session data
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 2fb6563..eb6c66f 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -952,7 +952,9 @@  struct rte_cryptodev_sym_session *
 
 /**
  * Frees private data for the device id, based on its device type,
- * returning it to its mempool.
+ * returning it to its mempool. It is the application's responsibility
+ * to ensure that private session data is not cleared while there are
+ * still in-flight operations using it.
  *
  * @param   dev_id   ID of device that uses the session.
  * @param   sess     Session containing the reference to the private data