[dpdk-dev,1/3] doc/crypto: update KASUMI installation section

Message ID 20180522124314.4674-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo May 22, 2018, 12:43 p.m. UTC
  Intel's libsso_kasumi library has been moved to a
new location, under "Intel Resource & Design Center".
The installation section of this PMD has been updated
to include the new instructions.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/cryptodevs/kasumi.rst | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
  

Comments

Kovacevic, Marko May 22, 2018, 1:04 p.m. UTC | #1
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  doc/guides/cryptodevs/kasumi.rst | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/guides/cryptodevs/kasumi.rst
> b/doc/guides/cryptodevs/kasumi.rst
> index f56b54758..c766a0eda 100644
> --- a/doc/guides/cryptodevs/kasumi.rst
> +++ b/doc/guides/cryptodevs/kasumi.rst
> @@ -34,11 +34,11 @@ Installation
>  ------------
> 
>  To build DPDK with the KASUMI_PMD the user is required to download -the
> export controlled ``libsso_kasumi`` library, by requesting it from -
> `<https://networkbuilders.intel.com/network-technologies/dpdk>`_.
> -Once approval has been granted, the user needs to log in -
> `<https://networkbuilders.intel.com/dpdklogin>`_
> -and click on "Kasumi Bit Stream crypto library" link, to download the library.
> +the export controlled ``libsso_kasumi`` library, by registering in
> +`<https://www.intel.com/content/www/us/en/design/resource-design-
> center.html>`_. 
 
I think it's better and nicer to have a nice embedded link :)

`Intel Resource Design Center <https://www.intel.com/content/www/us/en/design/resource-design-center.html>`_

> +Once approval has been granted, the user needs to search for *Kasumi F8
> +F9 3GPP cryptographic algorithms Software Library* to download the
> +library or directly through
> `<https://cdrdv2.intel.com/v1/dl/getContent/575866>`_.

For above link maybe have this 

"or directly through this `link <https://cdrdv2.intel.com/v1/dl/getContent/575866>`_"

>  After downloading the library, the user needs to unpack and compile it  on
> their system before building DPDK::

You can add my ack once changed

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
  
De Lara Guarch, Pablo May 22, 2018, 2:23 p.m. UTC | #2
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Tuesday, May 22, 2018 2:05 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 1/3] doc/crypto: update KASUMI installation
> section
> 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---

...

> 
> You can add my ack once changed
> 
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

Applied series with suggested changes to dpdk-next-crypto.

Thanks,
Pablo
  

Patch

diff --git a/doc/guides/cryptodevs/kasumi.rst b/doc/guides/cryptodevs/kasumi.rst
index f56b54758..c766a0eda 100644
--- a/doc/guides/cryptodevs/kasumi.rst
+++ b/doc/guides/cryptodevs/kasumi.rst
@@ -34,11 +34,11 @@  Installation
 ------------
 
 To build DPDK with the KASUMI_PMD the user is required to download
-the export controlled ``libsso_kasumi`` library, by requesting it from
-`<https://networkbuilders.intel.com/network-technologies/dpdk>`_.
-Once approval has been granted, the user needs to log in
-`<https://networkbuilders.intel.com/dpdklogin>`_
-and click on "Kasumi Bit Stream crypto library" link, to download the library.
+the export controlled ``libsso_kasumi`` library, by registering in
+`<https://www.intel.com/content/www/us/en/design/resource-design-center.html>`_.
+Once approval has been granted, the user needs to search for
+*Kasumi F8 F9 3GPP cryptographic algorithms Software Library* to download the
+library or directly through `<https://cdrdv2.intel.com/v1/dl/getContent/575866>`_.
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK::