[dpdk-dev] eal: deprecate function to set default mbuf pool
Checks
Commit Message
Deprecate rte_eal_mbuf_default_mempool_ops(), it shall be replaced by
rte_mbuf_best_mempool_ops().
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++--
lib/librte_eal/common/include/rte_eal.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
Comments
-----Original Message-----
> Date: Thu, 24 May 2018 11:44:07 +0200
> From: Olivier Matz <olivier.matz@6wind.com>
> To: dev@dpdk.org
> CC: Hemant Agrawal <hemant.agrawal@nxp.com>, Jerin Jacob
> <jerin.jacob@caviumnetworks.com>
> Subject: [PATCH] eal: deprecate function to set default mbuf pool
> X-Mailer: git-send-email 2.11.0
>
> Deprecate rte_eal_mbuf_default_mempool_ops(), it shall be replaced by
> rte_mbuf_best_mempool_ops().
>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Deprecate rte_eal_mbuf_default_mempool_ops(), it shall be replaced by
> rte_mbuf_best_mempool_ops().
>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
24/05/2018 12:08, Hemant Agrawal:
> > Deprecate rte_eal_mbuf_default_mempool_ops(), it shall be replaced by
> > rte_mbuf_best_mempool_ops().
> >
> > Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
@@ -32,8 +32,8 @@ Deprecation Notices
mempool names have been defined in ``rte_mbuf`` in v18.02. The uses of
``rte_eal_mbuf_default_mempool_ops`` shall be replaced by
``rte_mbuf_best_mempool_ops``.
- The following function is now redundant and it is target to be deprecated
- in 18.05:
+ The following function is deprecated since 18.05, and will be removed
+ in 18.08:
- ``rte_eal_mbuf_default_mempool_ops``
@@ -502,11 +502,13 @@ const char * __rte_experimental
rte_eal_mbuf_user_pool_ops(void);
/**
+ * @deprecated
* Get default pool ops name for mbuf
*
* @return
* returns default pool ops name.
*/
+__rte_deprecated
const char *
rte_eal_mbuf_default_mempool_ops(void);