diff mbox

[dpdk-dev] lib/librte_rawdev: fix compile error when using sanitizer

Message ID 1527218411-3305-1-git-send-email-cnliuhb@gmail.com (mailing list archive)
State Rejected, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Hongbo Liu May 25, 2018, 3:20 a.m. UTC 
  Otherwise, make will report the following error:
    rte_rawdevs is not flagged as experimental
    but is listed in version map
By command: EXTRA_CFLAGS="-fsanitize=address" make

Fixes: c88b3f2558 ("rawdev: introduce raw device library")
Cc: shreyansh.jain@nxp.com

Signed-off-by: Liu Hongbo <cnliuhb@gmail.com>
---
 lib/librte_rawdev/rte_rawdev_version.map | 1 -
 1 file changed, 1 deletion(-)

Comments

Shreyansh Jain May 25, 2018, 10:54 a.m. UTC | #1 
> -----Original Message-----
> From: Liu Hongbo [mailto:cnliuhb@gmail.com]
> Sent: Friday, May 25, 2018 8:50 AM
> To: dev@dpdk.org
> Cc: Shreyansh Jain <shreyansh.jain@nxp.com>; Liu Hongbo
> <cnliuhb@gmail.com>
> Subject: [PATCH] lib/librte_rawdev: fix compile error when using
> sanitizer
> 
> Otherwise, make will report the following error:
>     rte_rawdevs is not flagged as experimental
>     but is listed in version map
> By command: EXTRA_CFLAGS="-fsanitize=address" make
> 
> Fixes: c88b3f2558 ("rawdev: introduce raw device library")
> Cc: shreyansh.jain@nxp.com
> 
> Signed-off-by: Liu Hongbo <cnliuhb@gmail.com>
> ---
>  lib/librte_rawdev/rte_rawdev_version.map | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_rawdev/rte_rawdev_version.map
> b/lib/librte_rawdev/rte_rawdev_version.map
> index af4465e..7778f44 100644
> --- a/lib/librte_rawdev/rte_rawdev_version.map
> +++ b/lib/librte_rawdev/rte_rawdev_version.map
> @@ -28,7 +28,6 @@ EXPERIMENTAL {
>  	rte_rawdev_xstats_get;
>  	rte_rawdev_xstats_names_get;
>  	rte_rawdev_xstats_reset;
> -	rte_rawdevs;

Even before I could respond that compilation would fail, the patchwork system reported this error. http://dpdk.org/ml/archives/test-report/2018-May/054572.html

I am not sure what would be the problem. rte_rawdev is defined in experimental already and anyone using it would need the ALLOW_EXPERIMENTAL_API.

I tried with EXTRA_CFLAGS="-fsanitize=address" and it ran successfully. I am working on gcc 7.3.0 for x86_64.

> 
>  	local: *;
>  };
> --
> 2.7.4
diff mbox

Patch

diff --git a/lib/librte_rawdev/rte_rawdev_version.map b/lib/librte_rawdev/rte_rawdev_version.map
index af4465e..7778f44 100644
--- a/lib/librte_rawdev/rte_rawdev_version.map
+++ b/lib/librte_rawdev/rte_rawdev_version.map
@@ -28,7 +28,6 @@  EXPERIMENTAL {
 	rte_rawdev_xstats_get;
 	rte_rawdev_xstats_names_get;
 	rte_rawdev_xstats_reset;
-	rte_rawdevs;
 
 	local: *;
 };