[dpdk-dev] doc: remove old deprecation notice
Checks
Commit Message
New default configuration without flexible payload
is implemented now.
Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
Cc: stable@dpdk.org
Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ------
1 file changed, 6 deletions(-)
Comments
25/05/2018 11:17, Kirill Rybalchenko:
> New default configuration without flexible payload
> is implemented now.
>
> Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
The Fixes line should not reference the initial announce,
but the commit implementing it, because the deprecation notice should
have been removed while implementing the new API.
> Cc: stable@dpdk.org
You CC:stable because it was implemented in 18.02?
Hi Tomas,
> You CC:stable because it was implemented in 18.02
Sorry, I was misled by check-git-log script warning.
> > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
>
> The Fixes line should not reference the initial announce, but the commit
> implementing it, because the deprecation notice should have been removed
> while implementing the new API.
The actual fixline should be:
Fixes: d2f9fe8ae309 ("net/i40e: turn off flexible payload on driver init")
Shall I make v2 of this patch or you can apply it with those little fixes?
Thanks,
Kirill.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday 25 May 2018 11:51
> To: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>
> Cc: stable@dpdk.org; dev@dpdk.org; nhorman@tuxdriver.com; Mcnamara,
> John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-stable] [PATCH] doc: remove old deprecation notice
>
> 25/05/2018 11:17, Kirill Rybalchenko:
> > New default configuration without flexible payload is implemented now.
> >
> > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
>
> The Fixes line should not reference the initial announce, but the commit
> implementing it, because the deprecation notice should have been removed
> while implementing the new API.
>
> > Cc: stable@dpdk.org
>
> You CC:stable because it was implemented in 18.02?
>
>
25/05/2018 16:47, Rybalchenko, Kirill:
> Hi Tomas,
>
> > You CC:stable because it was implemented in 18.02
>
> Sorry, I was misled by check-git-log script warning.
>
> > > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
> >
> > The Fixes line should not reference the initial announce, but the commit
> > implementing it, because the deprecation notice should have been removed
> > while implementing the new API.
>
> The actual fixline should be:
>
> Fixes: d2f9fe8ae309 ("net/i40e: turn off flexible payload on driver init")
>
> Shall I make v2 of this patch or you can apply it with those little fixes?
OK I can fix it.
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Friday 25 May 2018 11:51
> > To: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; nhorman@tuxdriver.com; Mcnamara,
> > John <john.mcnamara@intel.com>; Kovacevic, Marko
> > <marko.kovacevic@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhang,
> > Qi Z <qi.z.zhang@intel.com>
> > Subject: Re: [dpdk-stable] [PATCH] doc: remove old deprecation notice
> >
> > 25/05/2018 11:17, Kirill Rybalchenko:
> > > New default configuration without flexible payload is implemented now.
> > >
> > > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
> >
> > The Fixes line should not reference the initial announce, but the commit
> > implementing it, because the deprecation notice should have been removed
> > while implementing the new API.
> >
> > > Cc: stable@dpdk.org
> >
> > You CC:stable because it was implemented in 18.02?
> >
> >
>
25/05/2018 16:56, Thomas Monjalon:
> 25/05/2018 16:47, Rybalchenko, Kirill:
> > Hi Tomas,
> >
> > > You CC:stable because it was implemented in 18.02
> >
> > Sorry, I was misled by check-git-log script warning.
> >
> > > > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS")
> > >
> > > The Fixes line should not reference the initial announce, but the commit
> > > implementing it, because the deprecation notice should have been removed
> > > while implementing the new API.
> >
> > The actual fixline should be:
> >
> > Fixes: d2f9fe8ae309 ("net/i40e: turn off flexible payload on driver init")
> >
> > Shall I make v2 of this patch or you can apply it with those little fixes?
>
> OK I can fix it.
Applied, thanks
@@ -59,12 +59,6 @@ Deprecation Notices
Target release for removal of the legacy API will be defined once most
PMDs have switched to rte_flow.
-* i40e: The default flexible payload configuration which extracts the first 16
- bytes of the payload for RSS will be deprecated starting from 18.02. If
- required the previous behavior can be configured using existing flow
- director APIs. There is no ABI/API break. This change will just remove a
- global configuration setting and require explicit configuration.
-
* pdump: As we changed to use generic IPC, some changes in APIs and structure
are expected in subsequent release.