diff mbox

[dpdk-dev] net/mlx5: fix error message in probe function

Message ID 20180525161428.13682-1-adrien.mazarguil@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Shahaf Shuler
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Adrien Mazarguil May 25, 2018, 4:15 p.m. UTC 
  Error values passed to strerror() must be positive.

Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity")
Cc: Shahaf Shuler <shahafs@mellanox.com>

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 drivers/net/mlx5/mlx5.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Yongseok Koh May 25, 2018, 4:46 p.m. UTC | #1 
> On May 25, 2018, at 9:16 AM, Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:
> 
> Error values passed to strerror() must be positive.
> 
> Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity")
> Cc: Shahaf Shuler <shahafs@mellanox.com>
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>

Thanks
Shahaf Shuler June 17, 2018, 8:05 a.m. UTC | #2 
Friday, May 25, 2018 7:46 PM, Yongseok Koh:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix error message in probe
> function
> 
> 
> > On May 25, 2018, at 9:16 AM, Adrien Mazarguil
> <adrien.mazarguil@6wind.com> wrote:
> >
> > Error values passed to strerror() must be positive.
> >
> > Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity")
> > Cc: Shahaf Shuler <shahafs@mellanox.com>
> >
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

> 
> Thanks
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 11b395b64..9b78f9879 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -953,9 +953,9 @@  mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 		priv->mtu = ETHER_MTU;
 		err = mlx5_args(&config, pci_dev->device.devargs);
 		if (err) {
-			DRV_LOG(ERR, "failed to process device arguments: %s",
-				strerror(err));
 			err = rte_errno;
+			DRV_LOG(ERR, "failed to process device arguments: %s",
+				strerror(rte_errno));
 			goto port_error;
 		}
 		err = mlx5_glue->query_device_ex(ctx, NULL, &device_attr_ex);