diff mbox

[dpdk-dev,v2] devtools: check orphan symbols in map files

Message ID 20180527215447.2841-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Thomas Monjalon May 27, 2018, 9:54 p.m. UTC 
  The script check-symbol-maps.sh finds the symbols exported
in a map file but not referenced in the codebase.

Suggested-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2:
    - rewrite Python script from Pavan in a smaller shell script
    - check symbol as whole word (-w)
    - print one symbol per line
---
 MAINTAINERS                   |  1 +
 devtools/check-symbol-maps.sh | 30 ++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100755 devtools/check-symbol-maps.sh

Comments

Thomas Monjalon May 29, 2018, 3:56 p.m. UTC | #1 
27/05/2018 23:54, Thomas Monjalon:
> The script check-symbol-maps.sh finds the symbols exported
> in a map file but not referenced in the codebase.
> 
> Suggested-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2:
>     - rewrite Python script from Pavan in a smaller shell script
>     - check symbol as whole word (-w)
>     - print one symbol per line
> ---
>  MAINTAINERS                   |  1 +
>  devtools/check-symbol-maps.sh | 30 ++++++++++++++++++++++++++++++

Applied
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index e56c72687..437777a22 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -81,6 +81,7 @@  F: devtools/check-dup-includes.sh
 F: devtools/check-maintainers.sh
 F: devtools/check-git-log.sh
 F: devtools/check-includes.sh
+F: devtools/check-symbol-maps.sh
 F: devtools/checkpatches.sh
 F: devtools/get-maintainer.sh
 F: devtools/git-log-fixes.sh
diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh
new file mode 100755
index 000000000..e137d48a4
--- /dev/null
+++ b/devtools/check-symbol-maps.sh
@@ -0,0 +1,30 @@ 
+#! /bin/sh -e
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 Mellanox Technologies, Ltd
+
+cd $(dirname $0)/..
+
+# speed up by ignoring Unicode details
+export LC_ALL=C
+
+find_orphan_symbols ()
+{
+    for map in $(find lib drivers -name '*.map') ; do
+        for sym in $(sed -rn 's,^([^}]*_.*);,\1,p' $map) ; do
+            if echo $sym | grep -q '^per_lcore_' ; then
+                continue
+            fi
+            if ! grep -q -r --exclude=$(basename $map) \
+                    -w $sym $(dirname $map) ; then
+                echo "$map: $sym"
+            fi
+        done
+    done
+}
+
+orphan_symbols=$(find_orphan_symbols)
+if [ -n "$orphan_symbols" ] ; then
+    echo "Found only in symbol map file:"
+    echo "$orphan_symbols" | sed 's,^,\t,'
+    exit 1
+fi