diff mbox

[dpdk-dev] compressdev: fix export of unknown symbols

Message ID 20180527222435.17001-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Thomas Monjalon May 27, 2018, 10:24 p.m. UTC 
  The *_callback_* functions are not implemented,
so they are removed from the export map file.

Fixes: ed7dd94f7f66 ("compressdev: add basic device management")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_compressdev/rte_compressdev_version.map | 3 ---
 1 file changed, 3 deletions(-)

Comments

De Lara Guarch, Pablo May 27, 2018, 10:51 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Sunday, May 27, 2018 11:25 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] compressdev: fix export of unknown symbols
> 
> The *_callback_* functions are not implemented, so they are removed from the
> export map file.
> 
> Fixes: ed7dd94f7f66 ("compressdev: add basic device management")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Thanks for spotting this, we removed these functions and forgot to
take them out from the map file.

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Thomas Monjalon May 28, 2018, 1:27 a.m. UTC | #2 
28/05/2018 00:51, De Lara Guarch, Pablo:
> > From: Thomas Monjalon
> > 
> > The *_callback_* functions are not implemented, so they are removed from the
> > export map file.
> > 
> > Fixes: ed7dd94f7f66 ("compressdev: add basic device management")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Thanks for spotting this, we removed these functions and forgot to
> take them out from the map file.
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied
diff mbox

Patch

diff --git a/lib/librte_compressdev/rte_compressdev_version.map b/lib/librte_compressdev/rte_compressdev_version.map
index e5cbc569e..6f900b673 100644
--- a/lib/librte_compressdev/rte_compressdev_version.map
+++ b/lib/librte_compressdev/rte_compressdev_version.map
@@ -1,8 +1,6 @@ 
 EXPERIMENTAL {
         global:
 
-	rte_compressdev_callback_register;
-	rte_compressdev_callback_unregister;
 	rte_compressdev_capability_get;
 	rte_compressdev_close;
 	rte_compressdev_configure;
@@ -15,7 +13,6 @@  EXPERIMENTAL {
 	rte_compressdev_info_get;
 	rte_compressdev_name_get;
 	rte_compressdev_pmd_allocate;
-	rte_compressdev_pmd_callback_process;
 	rte_compressdev_pmd_create;
 	rte_compressdev_pmd_destroy;
 	rte_compressdev_pmd_get_named_dev;