[v1] examples/ipsec-secgw: fix use of unsupported RSS offloads
Checks
Commit Message
Since commit aa1a6d87f15d ("ethdev: force RSS offload rules again")
a check that requested RSS offloads are supported by a PMD is
enforced, whereas in the past asking for unsupported offloads would
not result in an error. This patch changes the IPSec gateway sample
so that it only requests modes that are supported rather than
failing to start up.
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Signed-off-by: Remy Horton <remy.horton@intel.com>
---
examples/ipsec-secgw/ipsec-secgw.c | 5 +++++
1 file changed, 5 insertions(+)
Comments
On 22/06/2018 14:36, Remy Horton wrote:
[..]
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
> examples/ipsec-secgw/ipsec-secgw.c | 5 +++++
> 1 file changed, 5 insertions(+)
Self-Nack. Another pending patch already fixes this.
@@ -1566,6 +1566,11 @@ port_init(uint16_t portid)
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
local_port_conf.txmode.offloads |=
DEV_TX_OFFLOAD_MBUF_FAST_FREE;
+
+ /* Only request RSS offloads the NIC supports. */
+ local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
+ dev_info.flow_type_rss_offloads;
+
ret = rte_eth_dev_configure(portid, nb_rx_queue, nb_tx_queue,
&local_port_conf);
if (ret < 0)