diff mbox series

[v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG

Message ID 1530534656-12125-1-git-send-email-jananeex.m.parthasarathy@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers
Series [v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jananee Parthasarathy July 2, 2018, 12:30 p.m. UTC 
  From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com> 

For librte_cryptodev dynamic logging, conditional compilation of
debug logs would not be required anymore.

Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com> 
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Pablo de Lara Guarch <pablo.de.lara.guarch@intel.com>
---
v2: unused macro removed from config/common_base and rte_dev.h
---

 config/common_base                      | 1 -
 lib/librte_cryptodev/rte_cryptodev.h    | 8 --------
 lib/librte_eal/common/include/rte_dev.h | 1 -
 3 files changed, 10 deletions(-)

Comments

De Lara Guarch, Pablo July 2, 2018, 3:51 p.m. UTC | #1 
> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Monday, July 2, 2018 1:31 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Parthasarathy, JananeeX M
> <jananeex.m.parthasarathy@intel.com>
> Subject: [PATCH v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
> 
> From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> 
> For librte_cryptodev dynamic logging, conditional compilation of debug logs
> would not be required anymore.
> 
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> Reviewed-by: Pablo de Lara Guarch <pablo.de.lara.guarch@intel.com>
> ---
> v2: unused macro removed from config/common_base and rte_dev.h

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox series

Patch

diff --git a/config/common_base b/config/common_base
index 6541ad5b2..84317a9bd 100644
--- a/config/common_base
+++ b/config/common_base
@@ -460,7 +460,6 @@  CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW=n
 # Compile generic crypto device library
 #
 CONFIG_RTE_LIBRTE_CRYPTODEV=y
-CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
 CONFIG_RTE_CRYPTO_MAX_DEVS=64
 
 #
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index b7a4cf0a2..ccc0f73fd 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -38,7 +38,6 @@  extern const char **rte_cyptodev_names;
 		RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
 			RTE_FMT_TAIL(__VA_ARGS__,)))
 
-#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG
 #define CDEV_LOG_DEBUG(...) \
 	RTE_LOG(DEBUG, CRYPTODEV, \
 		RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
@@ -49,13 +48,6 @@  extern const char **rte_cyptodev_names;
 		RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
 			dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
 
-#else
-#define CDEV_LOG_DEBUG(...) (void)0
-#define CDEV_PMD_TRACE(...) (void)0
-#endif
-
-
-
 /**
  * A macro that points to an offset from the start
  * of the crypto operation structure (rte_crypto_op)
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index 3879ff3ca..d4b43512c 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -70,7 +70,6 @@  rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)
  * RTE_*_RET() macros defined below is compiled in debug mode.
  */
 #if defined(RTE_LIBRTE_ETHDEV_DEBUG) || \
-	defined(RTE_LIBRTE_CRYPTODEV_DEBUG) || \
 	defined(RTE_LIBRTE_EVENTDEV_DEBUG)
 #define RTE_PMD_DEBUG_TRACE(...) \
 	rte_pmd_debug_trace(__func__, __VA_ARGS__)