diff mbox series

[v1] lib/metrics: disallow NULL as metric name

Message ID 20180702134608.6805-1-remy.horton@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] lib/metrics: disallow NULL as metric name |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Remy Horton July 2, 2018, 1:46 p.m. UTC 
  This patch adds a sanity check so that names passed into
rte_metrics_reg_names() and the wrapper rte_metrics_reg_name()
cannot be NULL.

Fixes: 349950ddb9c5 ("metrics: add information metrics library")

Signed-off-by: Remy Horton <remy.horton@intel.com>
---
 lib/librte_metrics/rte_metrics.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ferruh Yigit July 20, 2018, 3:30 p.m. UTC | #1 
On 7/2/2018 2:46 PM, Remy Horton wrote:
> This patch adds a sanity check so that names passed into
> rte_metrics_reg_names() and the wrapper rte_metrics_reg_name()
> cannot be NULL.
> 
> Fixes: 349950ddb9c5 ("metrics: add information metrics library")
> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon July 26, 2018, 6:31 p.m. UTC | #2 
20/07/2018 17:30, Ferruh Yigit:
> On 7/2/2018 2:46 PM, Remy Horton wrote:
> > This patch adds a sanity check so that names passed into
> > rte_metrics_reg_names() and the wrapper rte_metrics_reg_name()
> > cannot be NULL.
> > 
> > Fixes: 349950ddb9c5 ("metrics: add information metrics library")
> > 
> > Signed-off-by: Remy Horton <remy.horton@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c
index 258f058..2275244 100644
--- a/lib/librte_metrics/rte_metrics.c
+++ b/lib/librte_metrics/rte_metrics.c
@@ -96,6 +96,9 @@  rte_metrics_reg_names(const char * const *names, uint16_t cnt_names)
 	/* Some sanity checks */
 	if (cnt_names < 1 || names == NULL)
 		return -EINVAL;
+	for (idx_name = 0; idx_name < cnt_names; idx_name++)
+		if (names[idx_name] == NULL)
+			return -EINVAL;
 
 	memzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME);
 	if (memzone == NULL)