diff mbox series

[1/3] compress/isal: fix logtype name

Message ID 20180711063846.47189-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers
Series [1/3] compress/isal: fix logtype name |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo July 11, 2018, 6:38 a.m. UTC 
  There is a naming convention for logtypes of PMDs:
"pmd.driverType.driverName".
Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal".

Fixes: 490e725b95b2 ("compress/isal: add device init and de-init")
Cc: stable@dpdk.org

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 drivers/compress/isal/isal_compress_pmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daly, Lee July 11, 2018, 4:14 p.m. UTC | #1 
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, July 11, 2018 7:39 AM
> To: Daly, Lee <lee.daly@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 1/3] compress/isal: fix logtype name
> 
> There is a naming convention for logtypes of PMDs:
> "pmd.driverType.driverName".
> Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal".
> 
> Fixes: 490e725b95b2 ("compress/isal: add device init and de-init")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  drivers/compress/isal/isal_compress_pmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/compress/isal/isal_compress_pmd.c
> b/drivers/compress/isal/isal_compress_pmd.c
> index 0f025a3bf..a3b28f29b 100644
> --- a/drivers/compress/isal/isal_compress_pmd.c
> +++ b/drivers/compress/isal/isal_compress_pmd.c
> @@ -465,7 +465,7 @@ RTE_INIT(isal_init_log);  static void
>  isal_init_log(void)
>  {
> -	isal_logtype_driver = rte_log_register("comp_isal");
> +	isal_logtype_driver = rte_log_register("pmd.compress.isal");
>  	if (isal_logtype_driver >= 0)
>  		rte_log_set_level(isal_logtype_driver, RTE_LOG_INFO);  }
> --
> 2.14.4
Acked-by: Lee Daly <lee.daly@intel.com>
De Lara Guarch, Pablo July 13, 2018, 2:40 p.m. UTC | #2 
> -----Original Message-----
> From: Daly, Lee
> Sent: Wednesday, July 11, 2018 5:15 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH 1/3] compress/isal: fix logtype name
> 
> 
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, July 11, 2018 7:39 AM
> > To: Daly, Lee <lee.daly@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > Subject: [PATCH 1/3] compress/isal: fix logtype name
> >
> > There is a naming convention for logtypes of PMDs:
> > "pmd.driverType.driverName".
> > Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal".
> >
> > Fixes: 490e725b95b2 ("compress/isal: add device init and de-init")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> >  drivers/compress/isal/isal_compress_pmd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/compress/isal/isal_compress_pmd.c
> > b/drivers/compress/isal/isal_compress_pmd.c
> > index 0f025a3bf..a3b28f29b 100644
> > --- a/drivers/compress/isal/isal_compress_pmd.c
> > +++ b/drivers/compress/isal/isal_compress_pmd.c
> > @@ -465,7 +465,7 @@ RTE_INIT(isal_init_log);  static void
> >  isal_init_log(void)
> >  {
> > -	isal_logtype_driver = rte_log_register("comp_isal");
> > +	isal_logtype_driver = rte_log_register("pmd.compress.isal");
> >  	if (isal_logtype_driver >= 0)
> >  		rte_log_set_level(isal_logtype_driver, RTE_LOG_INFO);  }
> > --
> > 2.14.4
> Acked-by: Lee Daly <lee.daly@intel.com>

Series applied to dpdk-next-crypto.

Thanks,
Pablo
diff mbox series

Patch

diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index 0f025a3bf..a3b28f29b 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -465,7 +465,7 @@  RTE_INIT(isal_init_log);
 static void
 isal_init_log(void)
 {
-	isal_logtype_driver = rte_log_register("comp_isal");
+	isal_logtype_driver = rte_log_register("pmd.compress.isal");
 	if (isal_logtype_driver >= 0)
 		rte_log_set_level(isal_logtype_driver, RTE_LOG_INFO);
 }