diff mbox series

app/crypto-perf: fix mempool create call failure

Message ID 1531739656-12288-1-git-send-email-radu.nicolau@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers
Series app/crypto-perf: fix mempool create call failure |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Radu Nicolau July 16, 2018, 11:14 a.m. UTC 
  Using a small number of sessions results in rte_mempool_create call
with cache_size > n, which fails. There is no need to cache the elements,
as there is no performance impact.

Fixes: 501c0a3b14c3 ("app/crypto-perf: limit number of sessions")
Cc: stable@dpdk.org

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 app/test-crypto-perf/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Akhil Goyal July 16, 2018, 11:39 a.m. UTC | #1 
On 7/16/2018 4:44 PM, Radu Nicolau wrote:

> Using a small number of sessions results in rte_mempool_create call
> with cache_size > n, which fails. There is no need to cache the elements,
> as there is no performance impact.
>
> Fixes: 501c0a3b14c3 ("app/crypto-perf: limit number of sessions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---

This patch should not be for stable. As the patch which introduced this issue is still not released.

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
De Lara Guarch, Pablo July 16, 2018, 2:13 p.m. UTC | #2 
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Monday, July 16, 2018 12:40 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] app/crypto-perf: fix mempool create call failure
> 
> On 7/16/2018 4:44 PM, Radu Nicolau wrote:
> 
> > Using a small number of sessions results in rte_mempool_create call
> > with cache_size > n, which fails. There is no need to cache the
> > elements, as there is no performance impact.
> >
> > Fixes: 501c0a3b14c3 ("app/crypto-perf: limit number of sessions")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> > ---
> 
> This patch should not be for stable. As the patch which introduced this issue is
> still not released.
> 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 

Applied to dpdk-next-crypto, removing the Cc stable line.

Thanks,
Pablo
diff mbox series

Patch

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 34873af..5c7dadb 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -21,7 +21,6 @@ 
 #include "cperf_test_verify.h"
 #include "cperf_test_pmd_cyclecount.h"
 
-#define SESS_MEMPOOL_CACHE_SIZE 64
 
 const char *cperf_test_type_strs[] = {
 	[CPERF_TEST_TYPE_THROUGHPUT] = "throughput",
@@ -204,7 +203,7 @@  cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs,
 			sess_mp = rte_mempool_create(mp_name,
 						sessions_needed,
 						max_sess_size,
-						SESS_MEMPOOL_CACHE_SIZE,
+						0,
 						0, NULL, NULL, NULL,
 						NULL, socket_id,
 						0);