diff mbox series

ixgbe: wait longer for link after fiber MAC setup

Message ID 20180716163604.31896-1-mgsmith@netgate.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series ixgbe: wait longer for link after fiber MAC setup |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Matthew Smith July 16, 2018, 4:36 p.m. UTC 
  After setting up the link on a fiber port, the maximum wait time for
the link to come up is 500 ms in ixgbe_setup_mac_link_multispeed_fiber().
On an x550 SFP+ port, this is often not sufficiently long for the link
to come up. This can result in never being able to retrieve accurate
link status for the port using rte_eth_link_get_nowait().

Increase the maximum wait time in ixgbe_setup_mac_link_multispeed_fiber()
to 1 s.

Bugzilla ID: 69
Fixes: f3430431abaf ("ixgbe/base: add SFP+ dual-speed support")
Cc: stable@dpdk.org

Signed-off-by: Matthew Smith <mgsmith@netgate.com>
---
 drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qi Zhang Sept. 30, 2018, 2:15 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org]
> Sent: Tuesday, July 17, 2018 12:36 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Matthew Smith <mgsmith@netgate.com>
> Subject: [dpdk-dev] [PATCH] ixgbe: wait longer for link after fiber MAC setup
> 
> After setting up the link on a fiber port, the maximum wait time for the link to
> come up is 500 ms in ixgbe_setup_mac_link_multispeed_fiber().
> On an x550 SFP+ port, this is often not sufficiently long for the link to come up.
> This can result in never being able to retrieve accurate link status for the port
> using rte_eth_link_get_nowait().
> 
> Increase the maximum wait time in ixgbe_setup_mac_link_multispeed_fiber()
> to 1 s.
> 
> Bugzilla ID: 69
> Fixes: f3430431abaf ("ixgbe/base: add SFP+ dual-speed support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Matthew Smith <mgsmith@netgate.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
index e7e9256e5..2fb0a072c 100644
--- a/drivers/net/ixgbe/base/ixgbe_common.c
+++ b/drivers/net/ixgbe/base/ixgbe_common.c
@@ -5296,7 +5296,7 @@  s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,
 		 * Section 73.10.2, we may have to wait up to 500ms if KR is
 		 * attempted.  82599 uses the same timing for 10g SFI.
 		 */
-		for (i = 0; i < 5; i++) {
+		for (i = 0; i < 10; i++) {
 			/* Wait for the link partner to also set speed */
 			msec_delay(100);