diff mbox series

[v2,2/2] app/testpmd: fix help string for tm commit cmd

Message ID 20180718095443.31429-1-krzysztof.kanas@caviumnetworks.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series None |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Krzysztof Kanas July 18, 2018, 9:54 a.m. UTC 
  Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field")
Cc: krzysztof.kanas@caviumnetworks.com

Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
---
v2:
* Fix the Fixes commit message line
---
 app/test-pmd/cmdline_tm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Iremonger, Bernard July 24, 2018, 9:08 a.m. UTC | #1 
Hi Krzysztof

> -----Original Message-----
> From: Krzysztof Kanas [mailto:krzysztof.kanas@caviumnetworks.com]
> Sent: Wednesday, July 18, 2018 10:55 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>;
> krzysztof.kanas@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH v2 2/2] app/testpmd: fix help string for tm commit cmd
> 
> Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field")
> Cc: krzysztof.kanas@caviumnetworks.com
> 
> Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
> ---
> v2:
> * Fix the Fixes commit message line
> ---
>  app/test-pmd/cmdline_tm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index
> 4f515241703a..09acc1b87293 100644
> --- a/app/test-pmd/cmdline_tm.c
> +++ b/app/test-pmd/cmdline_tm.c
> @@ -2172,7 +2172,7 @@ static void
> cmd_port_tm_hierarchy_commit_parsed(void *parsed_result,
> cmdline_parse_inst_t cmd_port_tm_hierarchy_commit = {
>  	.f = cmd_port_tm_hierarchy_commit_parsed,
>  	.data = NULL,
> -	.help_str = "Set port tm node shaper profile",
> +	.help_str = "Commit port tm hierarchy",
>  	.tokens = {
>  		(void *)&cmd_port_tm_hierarchy_commit_port,
>  		(void *)&cmd_port_tm_hierarchy_commit_tm,
> --
> 2.18.0

The check-git-log script is still showing an error:

./devtools/check-git-log.sh -1
Wrong 'Fixes' reference:
        Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field")

It is better to send the complete patch set (2 patches) with each revision.
My ack can be carried forward on the first patch.

Regards,

Bernard.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
index 4f515241703a..09acc1b87293 100644
--- a/app/test-pmd/cmdline_tm.c
+++ b/app/test-pmd/cmdline_tm.c
@@ -2172,7 +2172,7 @@  static void cmd_port_tm_hierarchy_commit_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_port_tm_hierarchy_commit = {
 	.f = cmd_port_tm_hierarchy_commit_parsed,
 	.data = NULL,
-	.help_str = "Set port tm node shaper profile",
+	.help_str = "Commit port tm hierarchy",
 	.tokens = {
 		(void *)&cmd_port_tm_hierarchy_commit_port,
 		(void *)&cmd_port_tm_hierarchy_commit_tm,