diff mbox series

[v2] examples/flow_filtering: add rte_fdir_conf initialization

Message ID 1532159404-88843-1-git-send-email-rosen.xu@intel.com (mailing list archive)
State Superseded, archived
Headers
Series [v2] examples/flow_filtering: add rte_fdir_conf initialization |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xu, Rosen July 21, 2018, 7:50 a.m. UTC 
  Rte_fdir_conf of rte_eth_conf should be initialized before
port initialization. It is a workaround solution when work
with Intel I40e.

Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API")
Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>

v2 updates:

Comments

Ori Kam July 22, 2018, 6:33 a.m. UTC | #1 
> -----Original Message-----
> From: Rosen Xu [mailto:rosen.xu@intel.com]
> Sent: Saturday, July 21, 2018 10:50 AM
> To: dev@dpdk.org
> Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam
> <orika@mellanox.com>; walter.e.gilmore@intel.com; qi.z.zhang@intel.com;
> stable@dpdk.org
> Subject: [PATCH v2] examples/flow_filtering: add rte_fdir_conf initialization
> 
> Rte_fdir_conf of rte_eth_conf should be initialized before
> port initialization. It is a workaround solution when work
> with Intel I40e.
> 
> Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow
> API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> 
> v2 updates:
> ===========
>  - Take more test on I40e
>  - Add comments
> ---
>  examples/flow_filtering/main.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
> index f595034..73d646c 100644
> --- a/examples/flow_filtering/main.c
> +++ b/examples/flow_filtering/main.c
> @@ -132,6 +132,17 @@
>  				DEV_TX_OFFLOAD_SCTP_CKSUM  |
>  				DEV_TX_OFFLOAD_TCP_TSO,
>  		},
> +		/*
> +		 * Initialize fdir_conf of ete_eth_conf
> +		 * it is a workaround solution when work with Intel I40e
> +		 * and it is not the normal way
> +		 */
> +		.fdir_conf = {
> +			.mode = RTE_FDIR_MODE_PERFECT,
> +			.pballoc = RTE_FDIR_PBALLOC_64K,
> +			.status = RTE_FDIR_REPORT_STATUS,
> +			.drop_queue = 127,
> +		},
>  	};
>  	struct rte_eth_txconf txq_conf;
>  	struct rte_eth_rxconf rxq_conf;
> --
> 1.8.3.1

Just small comment I think work should be replaced with working.
Both in the commit log and code comment.

Acked-by: Ori Kam <orika@mellanox.com>

Thanks,
Ori
Xu, Rosen July 22, 2018, 10:37 a.m. UTC | #2 
Hi,

I have fixed it, thanks.

> -----Original Message-----
> From: Ori Kam [mailto:orika@mellanox.com]
> Sent: Sunday, July 22, 2018 14:34
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Gilmore, Walter E
> <walter.e.gilmore@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> stable@dpdk.org
> Subject: RE: [PATCH v2] examples/flow_filtering: add rte_fdir_conf
> initialization
> 
> 
> 
> > -----Original Message-----
> > From: Rosen Xu [mailto:rosen.xu@intel.com]
> > Sent: Saturday, July 21, 2018 10:50 AM
> > To: dev@dpdk.org
> > Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam
> > <orika@mellanox.com>; walter.e.gilmore@intel.com;
> > qi.z.zhang@intel.com; stable@dpdk.org
> > Subject: [PATCH v2] examples/flow_filtering: add rte_fdir_conf
> > initialization
> >
> > Rte_fdir_conf of rte_eth_conf should be initialized before port
> > initialization. It is a workaround solution when work with Intel I40e.
> >
> > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow
> > API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> >
> > v2 updates:
> > ===========
> >  - Take more test on I40e
> >  - Add comments
> > ---
> >  examples/flow_filtering/main.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/examples/flow_filtering/main.c
> > b/examples/flow_filtering/main.c index f595034..73d646c 100644
> > --- a/examples/flow_filtering/main.c
> > +++ b/examples/flow_filtering/main.c
> > @@ -132,6 +132,17 @@
> >  				DEV_TX_OFFLOAD_SCTP_CKSUM  |
> >  				DEV_TX_OFFLOAD_TCP_TSO,
> >  		},
> > +		/*
> > +		 * Initialize fdir_conf of ete_eth_conf
> > +		 * it is a workaround solution when work with Intel I40e
> > +		 * and it is not the normal way
> > +		 */
> > +		.fdir_conf = {
> > +			.mode = RTE_FDIR_MODE_PERFECT,
> > +			.pballoc = RTE_FDIR_PBALLOC_64K,
> > +			.status = RTE_FDIR_REPORT_STATUS,
> > +			.drop_queue = 127,
> > +		},
> >  	};
> >  	struct rte_eth_txconf txq_conf;
> >  	struct rte_eth_rxconf rxq_conf;
> > --
> > 1.8.3.1
> 
> Just small comment I think work should be replaced with working.
> Both in the commit log and code comment.

It's fixed.

> Acked-by: Ori Kam <orika@mellanox.com>
> 
> Thanks,
> Ori
diff mbox series

Patch

===========
 - Take more test on I40e
 - Add comments
---
 examples/flow_filtering/main.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index f595034..73d646c 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -132,6 +132,17 @@ 
 				DEV_TX_OFFLOAD_SCTP_CKSUM  |
 				DEV_TX_OFFLOAD_TCP_TSO,
 		},
+		/*
+		 * Initialize fdir_conf of ete_eth_conf
+		 * it is a workaround solution when work with Intel I40e
+		 * and it is not the normal way
+		 */
+		.fdir_conf = {
+			.mode = RTE_FDIR_MODE_PERFECT,
+			.pballoc = RTE_FDIR_PBALLOC_64K,
+			.status = RTE_FDIR_REPORT_STATUS,
+			.drop_queue = 127,
+		},
 	};
 	struct rte_eth_txconf txq_conf;
 	struct rte_eth_rxconf rxq_conf;