diff mbox series

net/virtio-user: fix the param string

Message ID 20180730082804.20143-1-tiwei.bie@intel.com (mailing list archive)
State Accepted, archived
Headers
Series net/virtio-user: fix the param string |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tiwei Bie July 30, 2018, 8:28 a.m. UTC 
  Add the missing param "server" to param string.
Also add the missing spaces after params.

Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
Cc: stable@dpdk.org

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Maxime Coquelin July 30, 2018, 8:43 a.m. UTC | #1 
On 07/30/2018 10:28 AM, Tiwei Bie wrote:
> Add the missing param "server" to param string.
> Also add the missing spaces after params.
> 
> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> index 5ee59d5e5..525d16cab 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
>   	"cq=<int> "
>   	"queue_size=<int> "
>   	"queues=<int> "
> -	"iface=<string>"
> -	"mrg_rxbuf=<0|1>"
> +	"iface=<string> "
> +	"server=<0|1> "
> +	"mrg_rxbuf=<0|1> "
>   	"in_order=<0|1>");
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks!
Maxime
Tiwei Bie Aug. 1, 2018, 2:06 a.m. UTC | #2 
On Mon, Jul 30, 2018 at 10:43:37AM +0200, Maxime Coquelin wrote:
> On 07/30/2018 10:28 AM, Tiwei Bie wrote:
> > Add the missing param "server" to param string.
> > Also add the missing spaces after params.
> > 
> > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> >   drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> > index 5ee59d5e5..525d16cab 100644
> > --- a/drivers/net/virtio/virtio_user_ethdev.c
> > +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > @@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
> >   	"cq=<int> "
> >   	"queue_size=<int> "
> >   	"queues=<int> "
> > -	"iface=<string>"
> > -	"mrg_rxbuf=<0|1>"
> > +	"iface=<string> "
> > +	"server=<0|1> "
> > +	"mrg_rxbuf=<0|1> "
> >   	"in_order=<0|1>");
> > 
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 5ee59d5e5..525d16cab 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -681,6 +681,7 @@  RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
 	"cq=<int> "
 	"queue_size=<int> "
 	"queues=<int> "
-	"iface=<string>"
-	"mrg_rxbuf=<0|1>"
+	"iface=<string> "
+	"server=<0|1> "
+	"mrg_rxbuf=<0|1> "
 	"in_order=<0|1>");