diff mbox series

ethdev: ownership change log message priority change

Message ID 20180801174356.655-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Headers
Series ethdev: ownership change log message priority change |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger Aug. 1, 2018, 5:43 p.m. UTC 
  Changing ownership of a port is a normal event, and should
not be logged at ERR priority. Downgrade to a DEBUG message.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_ethdev/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matan Azrad Aug. 2, 2018, 6:40 a.m. UTC | #1 
From: Stephen Hemminger
> Changing ownership of a port is a normal event, and should not be logged at
> ERR priority. Downgrade to a DEBUG message.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Matan Azrad <matan@mellanox.com>
> ---
>  lib/librte_ethdev/rte_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 2e40c3fba99a..c7ab15722f98 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -463,7 +463,7 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const
> uint64_t old_owner_id,
> 
>  	port_owner->id = new_owner->id;
> 
> -	RTE_ETHDEV_LOG(ERR, "Port %u owner is %s_%016"PRIx64"\n",
> +	RTE_ETHDEV_LOG(DEBUG, "Port %u owner is %s_%016"PRIx64"\n",
>  		port_id, new_owner->name, new_owner->id);
> 
>  	return 0;
> --
> 2.18.0
Thomas Monjalon Aug. 2, 2018, 7 a.m. UTC | #2 
02/08/2018 08:40, Matan Azrad:
> 
> From: Stephen Hemminger
> > Changing ownership of a port is a normal event, and should not be logged at
> > ERR priority. Downgrade to a DEBUG message.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Matan Azrad <matan@mellanox.com>

Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")

Applied with this title:
	ethdev: decrease log level of ownership change
diff mbox series

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 2e40c3fba99a..c7ab15722f98 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -463,7 +463,7 @@  _rte_eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id,
 
 	port_owner->id = new_owner->id;
 
-	RTE_ETHDEV_LOG(ERR, "Port %u owner is %s_%016"PRIx64"\n",
+	RTE_ETHDEV_LOG(DEBUG, "Port %u owner is %s_%016"PRIx64"\n",
 		port_id, new_owner->name, new_owner->id);
 
 	return 0;