Message ID | 20180802205400.10316-1-yskoh@mellanox.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCCD31B505; Thu, 2 Aug 2018 22:54:21 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0065.outbound.protection.outlook.com [104.47.0.65]) by dpdk.org (Postfix) with ESMTP id 012581B4FC; Thu, 2 Aug 2018 22:54:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nb5Jn6lg68tnlxGY9P/P3E/XBauKy0MeTTIc7jPvinM=; b=bRFoeDD478zYi2zcmxRPLeLE8mWTyqlwSd8WGaQxQI1dpv3KjmisSBXbaUvuoW6ralQalo9lOk7fcCokAmjESocPBlLmj+TmvbtJ9fbdOpQPhRXJbmIXfHI6EJcF4BmrSWjeD2mjMYyqcPbepRrF3Eeu4AFQTin8ZoBGy4wIeMQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2034.eurprd05.prod.outlook.com (2603:10a6:203:1a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Thu, 2 Aug 2018 20:54:16 +0000 From: Yongseok Koh <yskoh@mellanox.com> To: shahafs@mellanox.com Cc: dev@dpdk.org, Yongseok Koh <yskoh@mellanox.com>, stable@dpdk.org Date: Thu, 2 Aug 2018 13:54:00 -0700 Message-Id: <20180802205400.10316-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR19CA0096.namprd19.prod.outlook.com (2603:10b6:320:1f::34) To AM5PR0501MB2034.eurprd05.prod.outlook.com (2603:10a6:203:1a::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9154606e-b53d-4d48-3cb0-08d5f8ba1d0e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2034; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2034; 3:CwyxShm8BVUTcoy3j5gXBHYcHH/6ZGNcRpWWCj5ZEU1hP4eUHuYmsguMRRD10focFB287xS7k06tsQDt0dtqTELvJot2sm87S2mmY9zrQHQ5a3YdqkEXN0JTvHArEUWoaq5IfPBVuq7k72z6ofcuaVkSc8NeTlcmDkuGy7HsRwwvlfr1DWMsF5ioHYhWcou5aIWm37IG4djMfD0ftEzxLZ6POEbsiCxHJT+i4p2UsnNTAlO/tbH3E4YE/hpdwpBr; 25:i+U6ZRtzbTBj2t2WWTUrGUMA++1BHoTTOqYrJJ34vQXtr7v39h2ndg8A8fAHWsEO5uAaDVU0VTRDb/tEjz/qrmsyakQBnIOkjIkmRY7/MsnxqtSVbz0uj4Mw5yHiEV99rqumkQq8KVGRDQvY1qej3oHMyVWO0FjuVY8WUlFjmd/e/iI1RB5SoF6zBOYI9wg4IQJFYtJjyo34B+RHqZW0NrdcET+ZJbL9wjUaaHh2z94cXXHxTsBxTDqQHSjGUb/JtgID4bZfgrsVM9hK1ToB6oHZ14LzJQaBeq4C+RFh3IuQnyaf62AHuuuXPMbTrhzQ0+il0FpfV7OTZfA6dcA7kw==; 31:THccv2OskUij4tA8bVUtnYV+Vn1Dpmgb3JxoYHsy9i/1FG3gmkck5xEnt4zfINPemTYQW+iCkgJ2NLMjJtizUtPKcVhX3GNScmpHsyPr8TlgNyxYMrQagmf1RjuL6RFoUdYG8xmZ4HnpptKLGcH2rrxveW+NnYysLDTWCDIpjrBHxVJQBTUJuYbr0w/xq/GROkUgXw5v+qPXRm/kLK62QlqwZBppB2ZbOq93uE8UA70= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2034: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2034; 20:tTmFQ83nQPbrVV1n+iDKo9SB1hneUPvqSd4AV+/C0THLIAmDK4hBBmBUkKgSc6ctAgHWpArVF2pfMmQl846caHMqev19Utz+uvn55dfLDBMmEuitZOPFudKoeo8IWhxnskWLg3MRWW/eTjkA21EEv8AeuETUOQcvgcBjzGAxkXeCTSfi1fMSTqE2g7OjNGD/QUEFFQtkgQzz/TzM78RT4VicoR9KXGZ5HnZGsAx1qFw2RF5GooA/mHJTsCjePLcBzNgaKakOeOa+qYJXByaRHzt9rv50ZCQe8j3i+VTRJACsGv3rtYLuFmnSm4bKF58ZOq/bLlGJzwXrGr1BsBLqrnEMR7iF7j7CRlO8jn1DvkPCk6fZ1hkUauMUfDXQe47h44bFYgCytK387O9kPfK1esf/rRwoyCasVySG9xoP4lBlxvDjl7wGeG1r5sLcyMcGnfFyQMVEUcpi9GVY+uq7k7kTbglUnk9bHAUcjR+/8A+iZJUrIcwS2fweOeWXGvuN; 4:Jvdydat3t1UVVq3ZF7Q7YXZCHJxu5PGa/iqxJKNIF8IYe+I9Z9BOVyyc7Duj/VM8rmYP7GaPC4Ou4Dtb2MexPHdAxYsZEqUUhvzjwWGUzXEX8L8ht9Dd7Ws9QtxJyKNVN9KfkYuZoaT031PcOnQv98QWL32FNh9XzzYYak+sAaRxWYyBlvC2AzYzWIt3UQkeCjdFK8wAT+EvWY663pu90rFoUG0BVVXycAVYBlfSuhcOCfGH1tVw+se04JJ7k8MVCjF86+jekdFPj+LRslT/mw== X-Microsoft-Antispam-PRVS: <AM5PR0501MB2034500B9EDCF64AC609B07DC32C0@AM5PR0501MB2034.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2034; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2034; X-Forefront-PRVS: 07521929C1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(346002)(396003)(39860400002)(189003)(199004)(316002)(6636002)(5660300001)(6666003)(53936002)(50226002)(34206002)(4326008)(450100002)(2906002)(8936002)(66066001)(1076002)(47776003)(2361001)(21086003)(36756003)(8676002)(55016002)(25786009)(305945005)(7736002)(81156014)(81166006)(6116002)(3846002)(386003)(7696005)(69596002)(105586002)(106356001)(51416003)(52116002)(478600001)(86362001)(97736004)(48376002)(2351001)(16526019)(486006)(1857600001)(16586007)(37006003)(476003)(956004)(2616005)(26005)(50466002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2034; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2034; 23:cnVu1fCObAd4SHZK15rtMdvteZQ2z6X9GKsfCSq?= y4NsBLoBgnNLEekE+NuSF1QCvrFkKMTxUHJ/iuYgiJyI0B1E/zYGM/3LhK3CG3yM8d0n+6XGAUUp+Zs9MjWweF1uM0m8YnLA4IVFCqEA/2sytwEgAnTMcopvQT1Ued0syKHitg9njiPhX9CzwShiJFgwAmj1GJwm9lFoe6xA6Wa8VRjE/C5PZpwZdBDgtxZWtxMl4HTIR00tfLVV330Auq213bef8dPkd3aZcsQfS9KJwW8zeHQitJoASLPGtJA4lUGysnba5mzL17xm+VwdeOPkVCM2Yk9W0B+wOBW2SAyOPbnse28GvpueoXqOD1EHqG0ajyryxsA69VDaUN0ETetu3T22mZl9S9XUjvNJFd6XfT9Wvy8q9v4SDxEQRs1LQ0jjlVqUwZ2OpFHywYIh/qFbbIxrdVJEh6yHo7lSjf/4d6SqCxOnf+h9yIK+ejg0EKYq2MZZ3sRM2xfCY8CF4OiNwAsRjfIE1P+G0IyCUV085NzoPXbOjUqIBNcox1N3enOy1E8DkpdjiNGjN98Oh3TmLDZFsAl//ZPTPMotvNx5Is2SXrTV08UWi6TCHEoICKDhto6MM3w/vNniFdTjvY3hsHEK2EBu7VlHjITdhtmOab29SKlSLuEK/0/pWYoUAY/eTqAd1Ld9LXb4zHLMW2VlSySNDIYrjqRj4wLrnNnCjw64cGFlqFzuFNY/lq4scJ33GdYyAq/el8ym0WpHlnxlyV2tSnLaN8oUdpihOHmZPYh9hMY03wPtSVKOPdtZjySHy3iyxj3OuuVIAzEKen+WHaifLLdtf5jXyw5gq2k1Nm9Yy3HsGExYNXTPSUYifkS+bjUq+eWYi7NH/Wa9hf+oxaB4Ps/FOLONzSk7EJmZbJqzJ1nq783iZ05U+vqaEAmGDF2/g9dBdNYXNMoHfXiJoYbqTXeQFU2iBlpCGk8TCNvXYVk5JpUYrum+IWyIRwXrS8EYSVF6Q0jBicjhtIOs5Bs60i1wBAkWOWdJKXfK3q2m8hymQPM0n8L9TkB+z1Xgf2CtmAg23achAnbeTBeLYFBrhU2vtlZ70Zdoqri1MehylALA0PwWDHKpDQsjfq3vbrLwhS2Zxv136MKUZ+vEPChBXyBFp/4FDE3vc6Rx1msizZNxkEbpPe9nS7FJUY2i68AfQZgNyywD1XvlgO/KuWHSzZOJwlBfQd9YXldmt/AuD9nfCGo/AcjcnxNvKitE3ERTEv6c2Yj8yIT+aS8yP X-Microsoft-Antispam-Message-Info: GFkYpzi5yBQEqMhtvlMfGNJmSgxjyyM8+S71/rXgHJTSjtZQC9+F+Hk4JGISpEl3oSViMhF3Ofcq4Dh7tOuICRklxR0PLLeA2OKSVwRDE7bYSHCTtgcWJVhAccezKSGzHxt7gI+RrkFxMnGRnbd7p22EmvfxkO+Ww8E39SQzY8Hx+jBHiqun8AD/TW4mqAKAoON+QRbiAH+hD72dQ4jRrAe1W5PLM9VowqN+Ppi1NSGUo6O/CYYZoKwz2lKmOpsYdLiw7xb5r+a6VPXMGpVj+P+0aqKbjrB2TRpCf3bO/vDShs8lRYMIuRpiui1MYZegA52Vy4esfXkeL/pgrz0uqRFkKwQiO5Rrakz8CPKw+bg= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2034; 6:6PRFGACHA4tzX64AlZxvWFHbcJ/wbpR0TksWahYs5NPuUaDrC7wXVkwN7imehSQmIJCufTchrkQSy9fdZUJzeiTgPOIczfxEu6820DwRLzrgdTzfzw6AYihyv+44cVlNciMzfd0BV1JMc/7Zw1tR7IFVvUFEJ44gxkiIr9prDZXja6MTw5Pn716VGRnWkf6nX5C72qswZQsTgfL/PTAqNYbmRfjWiu3HYMuWUPpy4yIDJduV4BmLxYAAWM8euJG4IUPmSoi2aRGfRBHDsbU9sTeXfmgNvy5Jnwz+IskiWwVDoyp8RWFy+gvndW7uMoh365sRd+i6jllUthsoQp6cS9HREkX4sul7DfarR8+CQAXtVN8Oqxg8yz8EgpujsKfM73nx7w+0d42LqWiZfNWsG6teEjXpU3WJjjj90eUkJ7wj5ML4WNrknqwcAiq1guIUUHWGGjPd5U7D4F8IbmVvgA==; 5:BSlbLSuUm8aL1q2Bq6Iaq4fUq3DXykwcZBXXjTI9T3dvYn4me2XIdeQHKZ4xRKIebjv+rYuJixBZhDlP7Jh7fcc4qKh3/g4GGWOQZbHYdO7DKVstE53UV3/o8t6oBkxd0ddOjSs7d2zYpZxDn8rLnga/8CF40WszRCgQhO+OUb0=; 7:/8mIlNc65VsnBrvInVfRD1PJSJopZhHzdTUcWrMOX+6I7s/we9UpPtixF2e+xM3mcgZ7jtAIwfnkGJ8AJeFHczA87f6VJ33mECB3Xo+pdq6fBXlQwqpebv0dbBJlfwjcr54Yq2h/e4q5v9HnsOPMWGthluBaWsnXi3H13inKHEfm8e/5U9XiESbY0MjXXNqCpjbmK8vtoMg9kLQGDB+UatJ7a0W3FDi/ZwEReDhb0YgbPiSHMkOBgVY7tKuPkZHa SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2018 20:54:16.7572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9154606e-b53d-4d48-3cb0-08d5f8ba1d0e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2034 Subject: [dpdk-dev] [PATCH] net/mlx5: prohibit wildcard match for GRE protocol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net/mlx5: prohibit wildcard match for GRE protocol
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Yongseok Koh
Aug. 2, 2018, 8:54 p.m. UTC
Currently, driver sets full mask (0xffff) for GRE protocol to device. Until
it is changed, PMD can't support wildcard match.
Fixes: f4b901a46aec ("net/mlx5: add flow GRE item")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
Comments
Hi Koh From: Yongseok Koh > Currently, driver sets full mask (0xffff) for GRE protocol to device. Until it is > changed, PMD can't support wildcard match. > > Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> > --- > drivers/net/mlx5/mlx5_flow.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index > b7500ec9d6..83ac6cbb85 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1690,8 +1690,12 @@ mlx5_flow_item_gre(const struct rte_flow_item > *item, > RTE_FLOW_ERROR_TYPE_ITEM, > item, > "L3 Layer is missing"); > - if (!mask) > - mask = &rte_flow_item_gre_mask; > + if (!mask || mask->protocol != 0xffff) Why do you check !mask again, I think it's redundant.. no? I think we can support also mask->protocol = 0: In this case we just need to not specify a spec. > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ITEM, > + item, > + "wildcard match is not supported" > + " for protocol field of GRE"); > ret = mlx5_flow_item_acceptable > (item, (const uint8_t *)mask, > (const uint8_t *)&rte_flow_item_gre_mask, > -- > 2.11.0
Hi More info below... From: Matan Azrad > Hi Koh > > From: Yongseok Koh > > Currently, driver sets full mask (0xffff) for GRE protocol to device. > > Until it is changed, PMD can't support wildcard match. > > > > Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> > > --- > > drivers/net/mlx5/mlx5_flow.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > b/drivers/net/mlx5/mlx5_flow.c index > > b7500ec9d6..83ac6cbb85 100644 > > --- a/drivers/net/mlx5/mlx5_flow.c > > +++ b/drivers/net/mlx5/mlx5_flow.c > > @@ -1690,8 +1690,12 @@ mlx5_flow_item_gre(const struct rte_flow_item > > *item, > > RTE_FLOW_ERROR_TYPE_ITEM, > > item, > > "L3 Layer is missing"); > > - if (!mask) > > - mask = &rte_flow_item_gre_mask; > > + if (!mask || mask->protocol != 0xffff) > > Why do you check !mask again, I think it's redundant.. no? > > I think we can support also mask->protocol = 0: > In this case we just need to not specify a spec. Just to be more accurate: The case of !mask led to mask->protocol = 0xffff before this patch, so it's ok and should be supported. In addition, we can support also mask->protocol = 0 (means match all the gre protocol values) by remaining empty spec\mask to the verbs. It can be something like this; if (!mask) mask = &rte_flow_item_gre_mask; if (mask->protocol == 0) spec = NULL; else if (mask->protocol != 0xffff) ERROR! I checked the next flow: eth / ipv4 / gre It matched all the gre traffic(MLNX_OFED_LINUX-4.4-2.0.4.0). > > + return rte_flow_error_set(error, ENOTSUP, > > + RTE_FLOW_ERROR_TYPE_ITEM, > > + item, > > + "wildcard match is not supported" > > + " for protocol field of GRE"); > > ret = mlx5_flow_item_acceptable > > (item, (const uint8_t *)mask, > > (const uint8_t *)&rte_flow_item_gre_mask, > > -- > > 2.11.0
On Sun, Aug 05, 2018 at 12:01:01AM -0700, Matan Azrad wrote: > Hi > More info below... > > From: Matan Azrad > > Hi Koh > > > > From: Yongseok Koh > > > Currently, driver sets full mask (0xffff) for GRE protocol to device. > > > Until it is changed, PMD can't support wildcard match. > > > > > > Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> > > > --- > > > drivers/net/mlx5/mlx5_flow.c | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > > b/drivers/net/mlx5/mlx5_flow.c index > > > b7500ec9d6..83ac6cbb85 100644 > > > --- a/drivers/net/mlx5/mlx5_flow.c > > > +++ b/drivers/net/mlx5/mlx5_flow.c > > > @@ -1690,8 +1690,12 @@ mlx5_flow_item_gre(const struct rte_flow_item > > > *item, > > > RTE_FLOW_ERROR_TYPE_ITEM, > > > item, > > > "L3 Layer is missing"); > > > - if (!mask) > > > - mask = &rte_flow_item_gre_mask; > > > + if (!mask || mask->protocol != 0xffff) > > > > Why do you check !mask again, I think it's redundant.. no? > > > > I think we can support also mask->protocol = 0: > > In this case we just need to not specify a spec. Right. My original intention is to force users to use 'is' or 'spec' with full mask being specified not depending on the default mask. But error message isn't enough. And users know what the default mask is. > Just to be more accurate: > > The case of !mask led to mask->protocol = 0xffff before this patch, so it's ok and should be supported. > In addition, we can support also mask->protocol = 0 (means match all the gre protocol values) by remaining empty spec\mask to the verbs. > It can be something like this; > if (!mask) > mask = &rte_flow_item_gre_mask; > if (mask->protocol == 0) > spec = NULL; This shouldn't work. If spec is null, ibv_flow_spec_gre will have zeroed val and mask. And this will lead to protocol being zero with full mask in the driver. Also, we have one lacking validation check here - driver doesn't support c_ks_res0_ver yet. > else if (mask->protocol != 0xffff) > ERROR! > > I checked the next flow: > eth / ipv4 / gre > > It matched all the gre traffic(MLNX_OFED_LINUX-4.4-2.0.4.0). I figured out the reason for your false positive. This issue has already been fixed in the latest MOFED release and the patch is pending for upstream [1]. We should void this temp patch but document it appropriately instead as it can work well with the MOFED release but not with upstream kernel. Let's take it offline. [1] https://patchwork.kernel.org/patch/10498671/ Thanks, Yongseok
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index b7500ec9d6..83ac6cbb85 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1690,8 +1690,12 @@ mlx5_flow_item_gre(const struct rte_flow_item *item, RTE_FLOW_ERROR_TYPE_ITEM, item, "L3 Layer is missing"); - if (!mask) - mask = &rte_flow_item_gre_mask; + if (!mask || mask->protocol != 0xffff) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ITEM, + item, + "wildcard match is not supported" + " for protocol field of GRE"); ret = mlx5_flow_item_acceptable (item, (const uint8_t *)mask, (const uint8_t *)&rte_flow_item_gre_mask,