diff mbox series

kni: fix build on RHEL 7.5

Message ID 1533557167-7390-1-git-send-email-quzeyao@gmail.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series kni: fix build on RHEL 7.5 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

ZY Qiu Aug. 6, 2018, 12:06 p.m. UTC 
  Signed-off-by: Drocula <quzeyao@gmail.com>
---
 kernel/linux/kni/ethtool/igb/kcompat.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Ferruh Yigit Aug. 9, 2018, 9:59 a.m. UTC | #1 
On 8/6/2018 1:06 PM, Drocula wrote:
> Signed-off-by: Drocula <quzeyao@gmail.com>

+1 for fixing build error, hence
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

But it would be better to have more detail on the build error, why and when this
change required in RedHat side, it would be good if this information can make on
time, but not I am for still getting the patch.

Also we require "Name Surname" syntax for sign off, can you please provide this.

Thanks,
ferruh
ZY Qiu Aug. 9, 2018, 10:25 a.m. UTC | #2 
This patch Fix compilation errors on Centos 7.4 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.

On Thu, Aug 9, 2018, 17:59 Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 8/6/2018 1:06 PM, Drocula wrote:
> > Signed-off-by: Drocula <quzeyao@gmail.com>
>
> +1 for fixing build error, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> But it would be better to have more detail on the build error, why and
> when this
> change required in RedHat side, it would be good if this information can
> make on
> time, but not I am for still getting the patch.
>
> Also we require "Name Surname" syntax for sign off, can you please provide
> this.
>
> Thanks,
> ferruh
>
ZY Qiu Aug. 9, 2018, 10:33 a.m. UTC | #3 
Sorry for my mistake,
This patch  fixes compilation errors on Centos 7.5 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74.

See commit 37d477b6863e5c06e20be434b559d3a03d89f46a

-- Drocula Lambda

Thanks

On Aug 9, 2018 18:25, "Drocula" <quzeyao@gmail.com> wrote:

This patch Fix compilation errors on Centos 7.4 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.

On Thu, Aug 9, 2018, 17:59 Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 8/6/2018 1:06 PM, Drocula wrote:
> > Signed-off-by: Drocula <quzeyao@gmail.com>
>
> +1 for fixing build error, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> But it would be better to have more detail on the build error, why and
> when this
> change required in RedHat side, it would be good if this information can
> make on
> time, but not I am for still getting the patch.
>
> Also we require "Name Surname" syntax for sign off, can you please provide
> this.
>
> Thanks,
> ferruh
>
diff mbox series

Patch

diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
index 40a8d99..ae1b530 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux/kni/ethtool/igb/kcompat.h
@@ -3929,6 +3929,11 @@  static inline struct sk_buff *__kc__vlan_hwaccel_put_tag(struct sk_buff *skb,
 #endif
 #endif
 
+#if (defined(RHEL_RELEASE_CODE) && \
+	(RHEL_RELEASE_VERSION(7, 5) <= RHEL_RELEASE_CODE))
+#define ndo_change_mtu ndo_change_mtu_rh74
+#endif
+
 #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0)
 #define HAVE_PCI_ENABLE_MSIX
 #endif