diff mbox series

[v2] net/i40e: stop lldp before setting local lldp MIB

Message ID 20180806200545.32226-1-3chas3@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [v2] net/i40e: stop lldp before setting local lldp MIB |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Chas Williams Aug. 6, 2018, 8:05 p.m. UTC 
  From: "Charles (Chas) Williams" <chas3@att.com>

From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction
Update:

    Starting from NVM 5.02, if the Set Local LLDP MIB command is
    received while the DCBx specific agent is stopped, the command
    returns an EPERM error. If the command is received while the
    LLDP agent is stopped, it sets the local MIB without exchanging
    LLDP with peer, and returns SUCCESS.

This results in the harmless, but annoying, diagnostic:

    default dcb config fails. err = -53, aq_err = 1.

So, if possible (older firmwares cannot safely stop LLDP), stop the
lldp daemon when we are in software mod before we attempt to call
i40e_set_dcb_config.

Signed-off-by: Chas Williams <chas3@att.com>
---
 drivers/net/i40e/i40e_ethdev.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Qi Zhang Sept. 13, 2018, 12:30 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chas Williams
> Sent: Tuesday, August 7, 2018 4:06 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Charles (Chas) Williams <chas3@att.com>
> Subject: [dpdk-dev] [PATCH v2] net/i40e: stop lldp before setting local lldp MIB
> 
> From: "Charles (Chas) Williams" <chas3@att.com>
> 
> From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction
> Update:
> 
>     Starting from NVM 5.02, if the Set Local LLDP MIB command is
>     received while the DCBx specific agent is stopped, the command
>     returns an EPERM error. If the command is received while the
>     LLDP agent is stopped, it sets the local MIB without exchanging
>     LLDP with peer, and returns SUCCESS.
> 
> This results in the harmless, but annoying, diagnostic:
> 
>     default dcb config fails. err = -53, aq_err = 1.
> 
> So, if possible (older firmwares cannot safely stop LLDP), stop the lldp daemon
> when we are in software mod before we attempt to call i40e_set_dcb_config.
> 
> Signed-off-by: Chas Williams <chas3@att.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index a340540ef..de3761933 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -11232,6 +11232,16 @@  i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)
 	 * LLDP MIB change event.
 	 */
 	if (sw_dcb == TRUE) {
+		/* When using NVM 6.01 or later, the RX data path does
+		 * not hang if the FW LLDP is stopped.
+		 */
+		if (((hw->nvm.version >> 12) & 0xf) >= 6 &&
+		    ((hw->nvm.version >> 4) & 0xff) >= 1) {
+			ret = i40e_aq_stop_lldp(hw, TRUE, NULL);
+			if (ret != I40E_SUCCESS)
+				PMD_INIT_LOG(DEBUG, "Failed to stop lldp");
+		}
+
 		ret = i40e_init_dcb(hw);
 		/* If lldp agent is stopped, the return value from
 		 * i40e_init_dcb we expect is failure with I40E_AQ_RC_EPERM