diff mbox series

[RFC,2/2] ethdev: check received mbufs sanity

Message ID 1534176226-21911-2-git-send-email-david.marchand@6wind.com (mailing list archive)
State RFC, archived
Delegated to: Thomas Monjalon
Headers
Series [RFC,1/2] mbuf: add a sanity check on segment metadata |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand Aug. 13, 2018, 4:03 p.m. UTC 
  Let's check the mbufs given by the drivers directly in the rx handler.
The only drawback is that you need CONFIG_RTE_LIBRTE_MBUF_DEBUG to be set
for this to actually do some real checks.

Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 lib/librte_ethdev/rte_ethdev.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

David Marchand Aug. 24, 2018, 10:17 a.m. UTC | #1 
On Mon, Aug 13, 2018 at 6:03 PM, David Marchand
<david.marchand@6wind.com> wrote:
> Let's check the mbufs given by the drivers directly in the rx handler.
> The only drawback is that you need CONFIG_RTE_LIBRTE_MBUF_DEBUG to be set
> for this to actually do some real checks.

Comments ?
diff mbox series

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 7070e9a..8843307 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -3803,6 +3803,7 @@  rte_eth_rx_burst(uint16_t port_id, uint16_t queue_id,
 {
 	struct rte_eth_dev *dev = &rte_eth_devices[port_id];
 	uint16_t nb_rx;
+	uint16_t index;
 
 #ifdef RTE_LIBRTE_ETHDEV_DEBUG
 	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0);
@@ -3816,6 +3817,9 @@  rte_eth_rx_burst(uint16_t port_id, uint16_t queue_id,
 	nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id],
 				     rx_pkts, nb_pkts);
 
+	for (index = 0; index < nb_rx; index++)
+		__rte_mbuf_sanity_check(rx_pkts[index], 1);
+
 #ifdef RTE_ETHDEV_RXTX_CALLBACKS
 	if (unlikely(dev->post_rx_burst_cbs[queue_id] != NULL)) {
 		struct rte_eth_rxtx_callback *cb =