app/testpmd: fix duplicate exit
Checks
Commit Message
In interactive mode, when the "quit" command is issued, pmd_test_exit()
is being called twice, once through the "quit" command and the other
after termination of prompt.
Remove duplicated exit routine by removing call from "quit" command.
Steps to reproduce:
- Run testpmd in interactive mode.
- type "quit".
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Brian Archbold <brian.archbold@intel.com>
---
app/test-pmd/cmdline.c | 1 -
1 file changed, 1 deletion(-)
Comments
> -----Original Message-----
> From: Archbold, Brian
> Sent: Wednesday, August 22, 2018 7:05 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Archbold, Brian <brian.archbold@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix duplicate exit
>
> In interactive mode, when the "quit" command is issued, pmd_test_exit() is
> being called twice, once through the "quit" command and the other after
> termination of prompt.
>
> Remove duplicated exit routine by removing call from "quit" command.
>
> Steps to reproduce:
> - Run testpmd in interactive mode.
> - type "quit".
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Brian Archbold <brian.archbold@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
On 8/23/2018 12:16 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Archbold, Brian
>> Sent: Wednesday, August 22, 2018 7:05 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; Archbold, Brian <brian.archbold@intel.com>;
>> stable@dpdk.org
>> Subject: [PATCH] app/testpmd: fix duplicate exit
>>
>> In interactive mode, when the "quit" command is issued, pmd_test_exit() is
>> being called twice, once through the "quit" command and the other after
>> termination of prompt.
>>
>> Remove duplicated exit routine by removing call from "quit" command.
>>
>> Steps to reproduce:
>> - Run testpmd in interactive mode.
>> - type "quit".
>>
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Brian Archbold <brian.archbold@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -7573,7 +7573,6 @@ static void cmd_quit_parsed(__attribute__((unused)) void *parsed_result,
struct cmdline *cl,
__attribute__((unused)) void *data)
{
- pmd_test_exit();
cmdline_quit(cl);
}