diff mbox series

[1/1] remove unnecessray fw declarations

Message ID 20180822143731.3971-1-ramirose@gmail.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [1/1] remove unnecessray fw declarations |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rami Rosen Aug. 22, 2018, 2:37 p.m. UTC 
  Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 app/test-pmd/testpmd.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Thomas Monjalon Nov. 18, 2018, 10:45 p.m. UTC | #1 
22/08/2018 16:37, Rami Rosen:
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id,
>  static void eth_dev_event_callback(char *device_name,
>  				enum rte_dev_event_type type,
>  				void *param);
> -static int eth_dev_event_callback_register(void);
> -static int eth_dev_event_callback_unregister(void);

I has been fixed by 2049c5113fe8 ("app/testpmd: use hotplug failure handler").

However I agree that some forward declarations could be removed,
ideally all.
Generally speaking, a lot of cleanup could be done in this file.
diff mbox series

Patch

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index ee48db2a3..8a31722db 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -435,9 +435,6 @@  static int eth_event_callback(portid_t port_id,
 static void eth_dev_event_callback(char *device_name,
 				enum rte_dev_event_type type,
 				void *param);
-static int eth_dev_event_callback_register(void);
-static int eth_dev_event_callback_unregister(void);
-
 
 /*
  * Check if all the ports are started.