[v2,1/4] build: include missing hypervisor files in Meson build
Checks
Commit Message
They are built by the legacy makefiles but not by Meson.
Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
Signed-off-by: Luca Boccassi <bluca@debian.org>
---
lib/librte_eal/common/arch/arm/meson.build | 2 +-
lib/librte_eal/common/arch/x86/meson.build | 2 +-
lib/librte_eal/common/meson.build | 2 ++
3 files changed, 4 insertions(+), 2 deletions(-)
Comments
On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote:
> They are built by the legacy makefiles but not by Meson.
>
> Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
31/08/2018 13:00, Bruce Richardson:
> On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote:
> > They are built by the legacy makefiles but not by Meson.
> >
> > Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Should we add "Cc: stable@dpdk.org" for the whole series?
On Sun, Sep 16, 2018 at 11:00:24AM +0200, Thomas Monjalon wrote:
> 31/08/2018 13:00, Bruce Richardson:
> > On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote:
> > > They are built by the legacy makefiles but not by Meson.
> > >
> > > Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
> > >
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Should we add "Cc: stable@dpdk.org" for the whole series?
>
Yes, it wouldn't hurt to do so.
On Mon, 2018-09-17 at 09:20 +0100, Bruce Richardson wrote:
> On Sun, Sep 16, 2018 at 11:00:24AM +0200, Thomas Monjalon wrote:
> > 31/08/2018 13:00, Bruce Richardson:
> > > On Fri, Aug 31, 2018 at 11:41:51AM +0100, Luca Boccassi wrote:
> > > > They are built by the legacy makefiles but not by Meson.
> > > >
> > > > Fixes: 8f40ee0734c8 ("eal/x86: get hypervisor name")
> > > >
> > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > >
> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > Should we add "Cc: stable@dpdk.org" for the whole series?
> >
>
> Yes, it wouldn't hurt to do so.
Done in v3, thanks
@@ -2,4 +2,4 @@
# Copyright(c) 2017 Intel Corporation.
eal_common_arch_sources = files('rte_cpuflags.c',
- 'rte_cycles.c')
+ 'rte_cycles.c', 'rte_hypervisor.c')
@@ -2,4 +2,4 @@
# Copyright(c) 2017 Intel Corporation
eal_common_arch_sources = files('rte_spinlock.c', 'rte_cpuflags.c',
- 'rte_cycles.c')
+ 'rte_cycles.c', 'rte_hypervisor.c')
@@ -14,6 +14,7 @@ common_sources = files(
'eal_common_errno.c',
'eal_common_fbarray.c',
'eal_common_hexdump.c',
+ 'eal_common_hypervisor.c',
'eal_common_launch.c',
'eal_common_lcore.c',
'eal_common_log.c',
@@ -59,6 +60,7 @@ common_headers = files(
'include/rte_errno.h',
'include/rte_fbarray.h',
'include/rte_hexdump.h',
+ 'include/rte_hypervisor.h',
'include/rte_interrupts.h',
'include/rte_keepalive.h',
'include/rte_launch.h',