diff mbox series

config: remove unused macro

Message ID 20180917073932.41822-1-qi.z.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series config: remove unused macro |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Qi Zhang Sept. 17, 2018, 7:39 a.m. UTC 
  RTE_LIBRTE_I40E_ITR_INTERVAL is not used. So it should also be removed
in config/rte_config.h for meson+ninjia build.

Fixes: 864a800d706d ("net/i40e: remove VF interrupt handler")
Cc: stable@dpdk.org

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 config/rte_config.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Bruce Richardson Sept. 17, 2018, 8:24 a.m. UTC | #1 
On Mon, Sep 17, 2018 at 03:39:32PM +0800, Qi Zhang wrote:
> RTE_LIBRTE_I40E_ITR_INTERVAL is not used. So it should also be removed
> in config/rte_config.h for meson+ninjia build.
> 
> Fixes: 864a800d706d ("net/i40e: remove VF interrupt handler")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

I like code removal.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Sept. 19, 2018, 1:56 p.m. UTC | #2 
17/09/2018 10:24, Bruce Richardson:
> On Mon, Sep 17, 2018 at 03:39:32PM +0800, Qi Zhang wrote:
> > RTE_LIBRTE_I40E_ITR_INTERVAL is not used. So it should also be removed
> > in config/rte_config.h for meson+ninjia build.
> > 
> > Fixes: 864a800d706d ("net/i40e: remove VF interrupt handler")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> I like code removal.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/config/rte_config.h b/config/rte_config.h
index a8e479774..f03c526ba 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -106,8 +106,6 @@ 
 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64
 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4
 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4
-/* interval up to 8160 us, aligned to 2 (or default value) */
-#define RTE_LIBRTE_I40E_ITR_INTERVAL -1
 
 /* Ring net PMD settings */
 #define RTE_PMD_RING_MAX_RX_RINGS 16