app/testpmd: clarify flow types in port info
Checks
Commit Message
In "show port info #" cmd output, "Supported flow types:" part is
not clear what flow types are listed.
Those are flow types that hash calculation offload supported by NIC.
Updated command output as "Supported RSS offload flow types:"
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
app/test-pmd/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, October 4, 2018 7:44 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH] app/testpmd: clarify flow types in port info
>
> In "show port info #" cmd output, "Supported flow types:" part is not clear what
> flow types are listed.
>
> Those are flow types that hash calculation offload supported by NIC.
> Updated command output as "Supported RSS offload flow types:"
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
On 10/5/2018 1:58 PM, Iremonger, Bernard wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Thursday, October 4, 2018 7:44 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: [PATCH] app/testpmd: clarify flow types in port info
>>
>> In "show port info #" cmd output, "Supported flow types:" part is not clear what
>> flow types are listed.
>>
>> Those are flow types that hash calculation offload supported by NIC.
>> Updated command output as "Supported RSS offload flow types:"
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Series applied to dpdk-next-net/master, thanks.
@@ -461,12 +461,12 @@ port_infos_display(portid_t port_id)
if (dev_info.reta_size > 0)
printf("Redirection table size: %u\n", dev_info.reta_size);
if (!dev_info.flow_type_rss_offloads)
- printf("No flow type is supported.\n");
+ printf("No RSS offload flow type is supported.\n");
else {
uint16_t i;
char *p;
- printf("Supported flow types:\n");
+ printf("Supported RSS offload flow types:\n");
for (i = RTE_ETH_FLOW_UNKNOWN + 1;
i < sizeof(dev_info.flow_type_rss_offloads) * CHAR_BIT; i++) {
if (!(dev_info.flow_type_rss_offloads & (1ULL << i)))