diff mbox series

[v1,2/9] app/procinfo: add compare for new options

Message ID 20181023135751.21536-2-vipin.varghese@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v1,1/9] app/procinfo: add usage for new debug |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Varghese, Vipin Oct. 23, 2018, 1:57 p.m. UTC 
  Add code for new debug options to compare usage strings and set
enable flag.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 app/proc-info/main.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Pattan, Reshma Oct. 25, 2018, 3:18 p.m. UTC | #1 
> -----Original Message-----
> From: Varghese, Vipin

> +/**< Enable port debug. */
In comment , Enable displaying port info?

> +static uint32_t enable_dbg_port;
Do you want to consider replacing "debug" to "show" in code here other places? As you have already changed the commands to "show."

				ring_name = optarg;
How about doing memcpy instead of pointer assignment? Similarly below. Though I don't see issue here. But safe to use memcpy.

> +			} else if (!strncmp(long_option[option_index].name,
> +					"dbg-mempool",
> MAX_LONG_OPT_SZ)) {
> +				enable_dbg_mempool = 1;
> +				mempool_name = optarg;
> +			}

Thanks,
Reshma
Varghese, Vipin Oct. 27, 2018, 7:17 a.m. UTC | #2 
HI

<snipped>
> 
> > +/**< Enable port debug. */
> In comment , Enable displaying port info?

ok

> 
> > +static uint32_t enable_dbg_port;
> Do you want to consider replacing "debug" to "show" in code here other
> places? As you have already changed the commands to "show."
> 

If the variable naming has to change, I can do

> 				ring_name = optarg;
> How about doing memcpy instead of pointer assignment? Similarly below.
> Though I don't see issue here. But safe to use memcpy.
> 

I will check this internally, I also think this is safe as it is pointer argv elements. I have taken the same design from

/* Print xstat single value given by name*/
if (!strncmp(long_option[option_index].name,
	"xstats-name", MAX_LONG_OPT_SZ)) {
	enable_xstats_name = 1;
	xstats_name = optarg;

<snipped>
diff mbox series

Patch

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 92854f5ba..5505d3fe3 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -63,6 +63,18 @@  static uint32_t mem_info;
 /**< Enable displaying xstat name. */
 static uint32_t enable_xstats_name;
 static char *xstats_name;
+/**< Enable port debug. */
+static uint32_t enable_dbg_port;
+/**< Enable tm debug. */
+static uint32_t enable_dbg_tm;
+/**< Enable crypto debug. */
+static uint32_t enable_dbg_crypto;
+/**< Enable ring debug. */
+static uint32_t enable_dbg_ring;
+static char *ring_name;
+/**< Enable mempool debug. */
+static uint32_t enable_dbg_mempool;
+static char *mempool_name;
 
 /**< Enable xstats by ids. */
 #define MAX_NB_XSTATS_IDS 1024
@@ -247,6 +259,24 @@  proc_info_parse_args(int argc, char **argv)
 			else if (!strncmp(long_option[option_index].name, "xstats-reset",
 					MAX_LONG_OPT_SZ))
 				reset_xstats = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"dbg-port", MAX_LONG_OPT_SZ))
+				enable_dbg_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"dbg-tm", MAX_LONG_OPT_SZ))
+				enable_dbg_tm = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"dbg-crypto", MAX_LONG_OPT_SZ))
+				enable_dbg_crypto = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"dbg-ring", MAX_LONG_OPT_SZ)) {
+				enable_dbg_ring = 1;
+				ring_name = optarg;
+			} else if (!strncmp(long_option[option_index].name,
+					"dbg-mempool", MAX_LONG_OPT_SZ)) {
+				enable_dbg_mempool = 1;
+				mempool_name = optarg;
+			}
 			break;
 		case 1:
 			/* Print xstat single value given by name*/