[v1,4/9] app/procinfo: add code for debug port
Checks
Commit Message
Function debug_port is used for displaying the port PMD under the
primary process. This covers basic and per queue configuration.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
app/proc-info/main.c | 113 ++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 112 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Tuesday, October 23, 2018 2:58 PM
> To: dev@dpdk.org; Tahhan, Maryam <maryam.tahhan@intel.com>; Pattan,
> Reshma <reshma.pattan@intel.com>
> Cc: Patel, Amol <amol.patel@intel.com>; Tummala, Sivaprasad
> <sivaprasad.tummala@intel.com>; Byrne, Stephen1
> <stephen1.byrne@intel.com>; Glynn, Michael J
> <michael.j.glynn@intel.com>; Varghese, Vipin <vipin.varghese@intel.com>
> Subject: [PATCH v1 4/9] app/procinfo: add code for debug port
>
> Function debug_port is used for displaying the port PMD under the primary
> process. This covers basic and per queue configuration.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> app/proc-info/main.c | 113
> ++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 112 insertions(+), 1 deletion(-)
>
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c index
> 5511fcb71..668f7febf 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -29,6 +29,9 @@
> #include <rte_branch_prediction.h>
> #include <rte_string_fns.h>
> #include <rte_metrics.h>
> +#include <rte_cycles.h>
> +#include <rte_security.h>
> +#include <rte_cryptodev.h>
>
> /* Maximum long option length for option parsing. */ #define
> MAX_LONG_OPT_SZ 64 @@ -40,6 +43,8 @@ #define STATS_BDR_STR(w, s)
> printf("%.*s%s%.*s\n", w, \
> STATS_BDR_FMT, s, w, STATS_BDR_FMT)
>
> +char bdr_str[100];
#define for marco size would be good. Instead of hard code.
> +
> + snprintf(bdr_str, 100, " debug - Port PMD %"PRIu64, rte_get_tsc_hz());
> + STATS_BDR_STR(10, bdr_str);
> +
> + RTE_ETH_FOREACH_DEV(i) {
> + uint16_t mtu = 0;
> + struct rte_eth_link link = {0};
Initialize structs using memset here and in other places.
> +
> + for (j = 0; j < dev_info.nb_rx_queues; j++) {
> +
> + ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);
> + if ((ret) || (rss_conf.rss_key == NULL))
> + continue;
> +
> + printf("\t -- RSS len %u key (hex):",
> + rss_conf.rss_key_len);
> + for (k = 0; k < rss_conf.rss_key_len; k++)
> + printf(" %x", rss_conf.rss_key[k]);
> + printf("\t -- hf 0x%"PRIx64"\n",
> + rss_conf.rss_hf);
Is this per port? not per queue. Can this be moved to outside of the queue for loop.
> + }
> +
> + printf(" - drop packet information\n");
Printf heading can be changed as it is printing input and output packets also.
> + ret = rte_eth_stats_get(i, &stats);
> + if (ret == 0) {
> + printf("\t -- input %"PRIu64
> + " output %"PRIu64"\n",
> + stats.ipackets,
> + stats.opackets);
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Tuesday, October 23, 2018 2:58 PM
> + printf("\t -- RSS len %u key (hex):",
Why "(hex)" in printf?
<snipped>
> > + printf("\t -- RSS len %u key (hex):",
>
> Why "(hex)" in printf?
In the follow up lines, we are disapplying the RSS key used in HEX values.
for (k = 0; k < rss_conf.rss_key_len; k++)
printf(" %x", rss_conf.rss_key[k]);
<snipped>
> >
> > +char bdr_str[100];
>
> #define for marco size would be good. Instead of hard code.
Yes, agreed.
<snipped>
> > + struct rte_eth_link link = {0};
>
> Initialize structs using memset here and in other places.
>
Will change for v3
<snipped>
> > + printf("\t -- RSS len %u key (hex):",
> > + rss_conf.rss_key_len);
> > + for (k = 0; k < rss_conf.rss_key_len; k++)
> > + printf(" %x", rss_conf.rss_key[k]);
> > + printf("\t -- hf 0x%"PRIx64"\n",
> > + rss_conf.rss_hf);
>
> Is this per port? not per queue. Can this be moved to outside of the queue for
> loop.
Yes, currently RSS is set for all rx queues so it is per port. I think I coded for upcoming feature rx RSS queue group,. I will correct and send v3.
> > + }
> > +
> > + printf(" - drop packet information\n");
>
> Printf heading can be changed as it is printing input and output packets also.
>
ok
@@ -29,6 +29,9 @@
#include <rte_branch_prediction.h>
#include <rte_string_fns.h>
#include <rte_metrics.h>
+#include <rte_cycles.h>
+#include <rte_security.h>
+#include <rte_cryptodev.h>
/* Maximum long option length for option parsing. */
#define MAX_LONG_OPT_SZ 64
@@ -40,6 +43,8 @@
#define STATS_BDR_STR(w, s) printf("%.*s%s%.*s\n", w, \
STATS_BDR_FMT, s, w, STATS_BDR_FMT)
+char bdr_str[100];
+
/**< mask of enabled ports */
static uint32_t enabled_port_mask;
/**< Enable stats. */
@@ -631,7 +636,113 @@ metrics_display(int port_id)
static void
debug_port(void)
{
- printf(" port");
+ uint16_t i = 0;
+ int ret = 0, j, k;
+
+ snprintf(bdr_str, 100, " debug - Port PMD %"PRIu64, rte_get_tsc_hz());
+ STATS_BDR_STR(10, bdr_str);
+
+ RTE_ETH_FOREACH_DEV(i) {
+ uint16_t mtu = 0;
+ struct rte_eth_link link = {0};
+ struct rte_eth_dev_info dev_info = {0};
+ struct rte_eth_rxq_info qinfo = {0};
+ struct rte_eth_stats stats = {0};
+ struct rte_eth_rss_conf rss_conf = {0};
+
+ snprintf(bdr_str, 100, " Port (%u)", i);
+ STATS_BDR_STR(5, bdr_str);
+ printf(" - generic config\n");
+
+ printf("\t -- Socket %d\n", rte_eth_dev_socket_id(i));
+ rte_eth_link_get(i, &link);
+ printf("\t -- link speed %d duplex %d,"
+ " auto neg %d status %d\n",
+ link.link_speed,
+ link.link_duplex,
+ link.link_autoneg,
+ link.link_status);
+ printf("\t -- promiscuous (%d)\n",
+ rte_eth_promiscuous_get(i));
+ ret = rte_eth_dev_get_mtu(i, &mtu);
+ if (ret == 0)
+ printf("\t -- mtu (%d)\n", mtu);
+
+ printf(" - queue\n");
+
+ rte_eth_dev_info_get(i, &dev_info);
+
+ for (j = 0; j < dev_info.nb_rx_queues; j++) {
+ ret = rte_eth_rx_queue_info_get(i, j, &qinfo);
+ if (ret == 0) {
+ printf("\t -- queue %d rx scatter %d"
+ " descriptors %d offloads 0x%"PRIx64
+ " mempool socket %d\n",
+ j,
+ qinfo.scattered_rx,
+ qinfo.nb_desc,
+ qinfo.conf.offloads,
+ qinfo.mp->socket_id);
+
+ ret = rte_eth_stats_get(i, &stats);
+ if (ret == 0) {
+ printf("\t -- packet input %"PRIu64
+ " output %"PRIu64""
+ " error %"PRIu64"\n",
+ stats.q_ipackets[j],
+ stats.q_opackets[j],
+ stats.q_errors[j]);
+ }
+ }
+
+ ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);
+ if ((ret) || (rss_conf.rss_key == NULL))
+ continue;
+
+ printf("\t -- RSS len %u key (hex):",
+ rss_conf.rss_key_len);
+ for (k = 0; k < rss_conf.rss_key_len; k++)
+ printf(" %x", rss_conf.rss_key[k]);
+ printf("\t -- hf 0x%"PRIx64"\n",
+ rss_conf.rss_hf);
+ }
+
+ printf(" - drop packet information\n");
+ ret = rte_eth_stats_get(i, &stats);
+ if (ret == 0) {
+ printf("\t -- input %"PRIu64
+ " output %"PRIu64"\n",
+ stats.ipackets,
+ stats.opackets);
+ printf("\t -- error input %"PRIu64
+ " output %"PRIu64"\n",
+ stats.ierrors,
+ stats.oerrors);
+ printf("\t -- RX no mbuf %"PRIu64"\n",
+ stats.rx_nombuf);
+ }
+
+ printf(" - cyrpto context\n");
+ void *ptr_ctx = rte_eth_dev_get_sec_ctx(i);
+ printf("\t -- security context - %p\n", ptr_ctx);
+
+ if (ptr_ctx) {
+ printf("\t -- size %u\n",
+ rte_security_session_get_size(ptr_ctx));
+ const struct rte_security_capability *ptr_sec_cap =
+ rte_security_capabilities_get(ptr_ctx);
+ if (ptr_sec_cap) {
+ printf("\t -- action (0x%x), protocol (0x%x),"
+ " offload flags (0x%x)\n",
+ ptr_sec_cap->action,
+ ptr_sec_cap->protocol,
+ ptr_sec_cap->ol_flags);
+ printf("\t -- capabilities - oper type %x\n",
+ ptr_sec_cap->crypto_capabilities->op);
+ }
+ }
+ }
+ STATS_BDR_STR(50, "");
}
static void