diff mbox series

[v1] net/ixgbe: update PMD Tx offload mask

Message ID 20181025134216.37416-1-zhirun.yan@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series [v1] net/ixgbe: update PMD Tx offload mask |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Yan, Zhirun Oct. 25, 2018, 1:42 p.m. UTC 
  Tx offload mask is updated in following commit:
commit 1037ed842c37 ("mbuf: fix Tx offload mask")
Currently, the new added offload flags will be
not supported in PMD and application will fail to
call PMD transmit prepare function.
This patch updates IXGBE_TX_OFFFLOAD_MASK.

Fixes: b161f72107 ("mbuf: remove too specific flags mask")
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Xiaolong Ye Oct. 25, 2018, 6:08 a.m. UTC | #1 
On 10/25, Zhirun Yan wrote:
>Tx offload mask is updated in following commit:
>commit 1037ed842c37 ("mbuf: fix Tx offload mask")
>Currently, the new added offload flags will be

s/will be/are

Thanks,
Xiaolong

>not supported in PMD and application will fail to
>call PMD transmit prepare function.
>This patch updates IXGBE_TX_OFFFLOAD_MASK.
>
>Fixes: b161f72107 ("mbuf: remove too specific flags mask")
>Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
>---
> drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
>index e6f61c900..d6e971440 100644
>--- a/drivers/net/ixgbe/ixgbe_rxtx.c
>+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
>@@ -58,6 +58,10 @@
> #endif
> /* Bit Mask to indicate what bits required for building TX context */
> #define IXGBE_TX_OFFLOAD_MASK (			 \
>+		PKT_TX_OUTER_IPV6 |		 \
>+		PKT_TX_OUTER_IPV4|		 \
>+		PKT_TX_IPV6 |			 \
>+		PKT_TX_IPV4 |			 \
> 		PKT_TX_VLAN_PKT |		 \
> 		PKT_TX_IP_CKSUM |		 \
> 		PKT_TX_L4_MASK |		 \
>-- 
>2.17.1
>
Yan, Zhirun Oct. 25, 2018, 7:02 a.m. UTC | #2 
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, October 25, 2018 2:09 PM
> To: Yan, Zhirun <zhirun.yan@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask
> 
> On 10/25, Zhirun Yan wrote:
> >Tx offload mask is updated in following commit:
> >commit 1037ed842c37 ("mbuf: fix Tx offload mask") Currently, the new
> >added offload flags will be
> 
> s/will be/are

Got it, I will modify in patch v2. 
Thanks!

> 
> Thanks,
> Xiaolong
> 
> >not supported in PMD and application will fail to call PMD transmit
> >prepare function.
> >This patch updates IXGBE_TX_OFFFLOAD_MASK.
> >
> >Fixes: b161f72107 ("mbuf: remove too specific flags mask")
> >Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> >---
> > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> >b/drivers/net/ixgbe/ixgbe_rxtx.c index e6f61c900..d6e971440 100644
> >--- a/drivers/net/ixgbe/ixgbe_rxtx.c
> >+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> >@@ -58,6 +58,10 @@
> > #endif
> > /* Bit Mask to indicate what bits required for building TX context */
> > #define IXGBE_TX_OFFLOAD_MASK (			 \
> >+		PKT_TX_OUTER_IPV6 |		 \
> >+		PKT_TX_OUTER_IPV4|		 \
> >+		PKT_TX_IPV6 |			 \
> >+		PKT_TX_IPV4 |			 \
> > 		PKT_TX_VLAN_PKT |		 \
> > 		PKT_TX_IP_CKSUM |		 \
> > 		PKT_TX_L4_MASK |		 \
> >--
> >2.17.1
> >
diff mbox series

Patch

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index e6f61c900..d6e971440 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -58,6 +58,10 @@ 
 #endif
 /* Bit Mask to indicate what bits required for building TX context */
 #define IXGBE_TX_OFFLOAD_MASK (			 \
+		PKT_TX_OUTER_IPV6 |		 \
+		PKT_TX_OUTER_IPV4|		 \
+		PKT_TX_IPV6 |			 \
+		PKT_TX_IPV4 |			 \
 		PKT_TX_VLAN_PKT |		 \
 		PKT_TX_IP_CKSUM |		 \
 		PKT_TX_L4_MASK |		 \