diff mbox series

examples/l3fwd-power: fix build with icc

Message ID 20181026220045.28739-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series examples/l3fwd-power: fix build with icc |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Thomas Monjalon Oct. 26, 2018, 10 p.m. UTC 
  main.c(376): error #592: variable "lcore_id" is used before its value is set
        RTE_SET_USED(lcore_id);
        ^

The variables were voided with RTE_SET_USED without an obvious reason.
Removing these voidings should avoid the icc error.

Fixes: a137d012 ("examples/l3fwd-power: support traffic pattern aware control")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 examples/l3fwd-power/main.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Ferruh Yigit Oct. 26, 2018, 10:13 p.m. UTC | #1 
On 10/26/2018 11:00 PM, Thomas Monjalon wrote:
> main.c(376): error #592: variable "lcore_id" is used before its value is set
>         RTE_SET_USED(lcore_id);
>         ^
> 
> The variables were voided with RTE_SET_USED without an obvious reason.
> Removing these voidings should avoid the icc error.
> 
> Fixes: a137d012 ("examples/l3fwd-power: support traffic pattern aware control")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon Oct. 26, 2018, 11:24 p.m. UTC | #2 
27/10/2018 00:13, Ferruh Yigit:
> On 10/26/2018 11:00 PM, Thomas Monjalon wrote:
> > main.c(376): error #592: variable "lcore_id" is used before its value is set
> >         RTE_SET_USED(lcore_id);
> >         ^
> > 
> > The variables were voided with RTE_SET_USED without an obvious reason.
> > Removing these voidings should avoid the icc error.
> > 
> > Fixes: a137d012 ("examples/l3fwd-power: support traffic pattern aware control")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied
diff mbox series

Patch

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index c07eeff10..0b3f8fe61 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -373,10 +373,6 @@  signal_exit_now(int sigtype)
 	unsigned int portid;
 	int ret;
 
-	RTE_SET_USED(lcore_id);
-	RTE_SET_USED(portid);
-	RTE_SET_USED(ret);
-
 	if (sigtype == SIGINT) {
 		if (empty_poll_on)
 			empty_poll_stop = true;