| Message ID | 1541485898-25572-1-git-send-email-orika@mellanox.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8EA282BE2; Tue, 6 Nov 2018 07:32:24 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40061.outbound.protection.outlook.com [40.107.4.61]) by dpdk.org (Postfix) with ESMTP id 408A82AA0 for <dev@dpdk.org>; Tue, 6 Nov 2018 07:32:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDiQAeq8q5M1bxJxNeo9ExlXHOLw+/4QYnwzgJPUyt0=; b=ngIH83GnLpRa6hABVwnmcR0gJRsHoFJo2oQhsCapqW/gCkg6x4nElthD77D3vQaP5QUANDM6HHY+aloL5Q3EGbiGYjRvXkTGvWzHMocKmHbm2NBXK1ugs1aFuPQaOmKmW99jtF1tqabPqP+0FoRhbXmkIcOVdlF2fpYimJkcZcc= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.187.142) by AM4PR05MB3154.eurprd05.prod.outlook.com (10.171.186.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.24; Tue, 6 Nov 2018 06:32:21 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::61ec:ffec:5ebf:7bd6]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::61ec:ffec:5ebf:7bd6%3]) with mapi id 15.20.1294.034; Tue, 6 Nov 2018 06:32:21 +0000 From: Ori Kam <orika@mellanox.com> To: Ori Kam <orika@mellanox.com>, "wei.zhao1@intel.com" <wei.zhao1@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH] examples/flow_filtering: fix capability setting Thread-Index: AQHUdZp47nbn2J5o4EGKqgxR79/jYA== Date: Tue, 6 Nov 2018 06:32:20 +0000 Message-ID: <1541485898-25572-1-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CWLP265CA0132.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:53::24) To AM4PR05MB3425.eurprd05.prod.outlook.com (2603:10a6:205:6::14) authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3154; 6:SiVc22bwjXiGZk/TdFAbqgYUHUlo0eDVY4+p4+5UaMjn62Vig/YutbeM9poXm+uR4XDNW/Z6hFRPDiXuYT1fJJ/OQ9ZjnApOvarf8EsotmADXbmDorb6BtXlMO4Aiom9it/9p4dHBFr9HZZSawvre3jHwjmKOXjH1bbqYZsflnGaiuebnU2BFawGaSy2gcWHRm2jnNbArdBzUsq9DOK0IzUCZ/B+1af+QvZw5rMuwqSBq0+bOEfeOskCh6Mq3F1nasbjZs3nwY+UO0dwkYnH9aETYbgJZ8apcaZfG4IKw0ZDyIQUbgo63skIPpoRNz1HgE6AZD5DLRfurrkYzWy8YuPQ8CDp199vFztI0Faa/mW8PCzI60Xp9fMgRw+zgUKQ8qyyNI6/G8pcOOH1l97P8TyILdnzxCvO6Y8VIkJIeMxDNW5JaZHvA1fbjCzrD/NgWYspuLofj8L6Gap+0a+a4Q==; 5:6udyC8hEsuqSNN8zYofw20YMzCaTb3N66DefliVV0dy3xGNdClv1MxM0JyvQJ/NaxgaEPuyM83s/ZUbOxuVFAhUP2MOJ3WGvvQjcibAbftoI0CiIjJ5acdn1jIB9MMr4uGEG7rD610TLuJNB16KHyA6kEh9UWb2zWF6KkX/roRk=; 7:HG6THtUOY76YI/SB8LgQi+CSgNTnAVg5PDwQ4NkbdS84UtjpO4QP7rcUQT0a5fxVtoZ1uszIWTSO5PBRAbyn5rkxLxyHwDjUmL29Vx6fON8mjaAxLXZZUMRUgGE01Hly3GwYdzbbm8onkB/KHzijMQ== x-ms-office365-filtering-correlation-id: 3c279390-7dc6-403c-09d3-08d643b19aae x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3154; x-ms-traffictypediagnostic: AM4PR05MB3154: x-microsoft-antispam-prvs: <AM4PR05MB3154383DF90593A2D3209515DBCB0@AM4PR05MB3154.eurprd05.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB3154; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3154; x-forefront-prvs: 0848C1A6AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39860400002)(136003)(396003)(189003)(199004)(52116002)(4326008)(186003)(386003)(6506007)(106356001)(6512007)(5660300001)(6436002)(25786009)(68736007)(478600001)(86362001)(14454004)(26005)(36756003)(53936002)(14444005)(102836004)(6486002)(305945005)(1857600001)(256004)(99286004)(2900100001)(110136005)(7736002)(2501003)(2906002)(476003)(97736004)(66066001)(6116002)(316002)(3846002)(8936002)(2616005)(71200400001)(105586002)(71190400001)(486006)(8676002)(81156014)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3154; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: HMXcO+2eakodI7oANeWKdwFVBP5v+0HrT+lg0rvllVjwZKFHd2So1zBpleJ59Fq+xvRHqrRukGBNOS9x3gug7FcYPYp5nYMFYAnga0v0M8TquiXPqxWGyF+8zNFW74bAG9M3fdXPCotCrK24ZcX8ypnpT13OCksiUUHZXeyfT9TwYveQKVriPc9fAhGbfd9tSjfV9hg7++MXvT7CnLzze+QvUBA34XhUDslXz+eT6yk16AvKpRqIm39bzvktsO2NJHuN6IBp1zl9NcZIAdIW5F9bWB+yhK2b22tFdcMj4pKqoglpvifYn2/GDAmsAv4eDHKv7CFsTR43q0O++rj5knZGVqPkgaOaDHUvBNN/O/4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c279390-7dc6-403c-09d3-08d643b19aae X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2018 06:32:20.9598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3154 Subject: [dpdk-dev] [PATCH] examples/flow_filtering: fix capability setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
examples/flow_filtering: fix capability setting
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Ori Kam
Nov. 6, 2018, 6:32 a.m. UTC
The tx offloads should be compared to tx capability
Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap")
Cc: orika@mellanox.com
Cc: wei.zhao1@intel.com
Signed-off-by: Ori Kam <orika@mellanox.com>
---
examples/flow_filtering/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Acked-by: Wei Zhao <wei.zhao1@intel.com> > -----Original Message----- > From: Ori Kam [mailto:orika@mellanox.com] > Sent: Tuesday, November 6, 2018 2:32 PM > To: Ori Kam <orika@mellanox.com>; Zhao1, Wei <wei.zhao1@intel.com> > Cc: dev@dpdk.org > Subject: [PATCH] examples/flow_filtering: fix capability setting > > The tx offloads should be compared to tx capability > > Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap") > Cc: orika@mellanox.com > Cc: wei.zhao1@intel.com > > Signed-off-by: Ori Kam <orika@mellanox.com> > --- > examples/flow_filtering/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c > index 27e287a..a582ac0 100644 > --- a/examples/flow_filtering/main.c > +++ b/examples/flow_filtering/main.c > @@ -137,7 +137,7 @@ > struct rte_eth_dev_info dev_info; > > rte_eth_dev_info_get(port_id, &dev_info); > - port_conf.txmode.offloads &= dev_info.rx_offload_capa; > + port_conf.txmode.offloads &= dev_info.tx_offload_capa; > printf(":: initializing port: %d\n", port_id); > ret = rte_eth_dev_configure(port_id, > nr_queues, nr_queues, &port_conf); > -- > 1.8.3.1
On 11/7/2018 2:43 AM, Zhao1, Wei wrote: > >> -----Original Message----- >> From: Ori Kam [mailto:orika@mellanox.com] >> Sent: Tuesday, November 6, 2018 2:32 PM >> To: Ori Kam <orika@mellanox.com>; Zhao1, Wei <wei.zhao1@intel.com> >> Cc: dev@dpdk.org >> Subject: [PATCH] examples/flow_filtering: fix capability setting >> >> The tx offloads should be compared to tx capability >> >> Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap") >> Cc: orika@mellanox.com >> Cc: wei.zhao1@intel.com >> >> Signed-off-by: Ori Kam <orika@mellanox.com> > > Acked-by: Wei Zhao <wei.zhao1@intel.com> Fixes: c82f2f8b4b3a ("examples/flow_filtering: filter out unsupported offloads") Cc: stable@dpdk.org Applied to dpdk-next-net/master, thanks.
diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c index 27e287a..a582ac0 100644 --- a/examples/flow_filtering/main.c +++ b/examples/flow_filtering/main.c @@ -137,7 +137,7 @@ struct rte_eth_dev_info dev_info; rte_eth_dev_info_get(port_id, &dev_info); - port_conf.txmode.offloads &= dev_info.rx_offload_capa; + port_conf.txmode.offloads &= dev_info.tx_offload_capa; printf(":: initializing port: %d\n", port_id); ret = rte_eth_dev_configure(port_id, nr_queues, nr_queues, &port_conf);