examples/fips_validation: fix uninitialized pointer read

Message ID 20181107120006.3779-1-marko.kovacevic@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series examples/fips_validation: fix uninitialized pointer read |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Kovacevic, Marko Nov. 7, 2018, noon UTC
  Fixing a bug raised in coverity using
uninitialized value.

Coverity issue: 325881
Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing")
Cc: marko.kovacevic@intel.com

Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
 examples/fips_validation/fips_validation_tdes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Thomas Monjalon Nov. 7, 2018, 1:55 p.m. UTC | #1
07/11/2018 13:00, Marko Kovacevic:
> Fixing a bug raised in coverity using
> uninitialized value.
> 
> Coverity issue: 325881
> Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing")
> Cc: marko.kovacevic@intel.com
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>

Applied, thanks
  

Patch

diff --git a/examples/fips_validation/fips_validation_tdes.c b/examples/fips_validation/fips_validation_tdes.c
index 5064ff3..15ee434 100644
--- a/examples/fips_validation/fips_validation_tdes.c
+++ b/examples/fips_validation/fips_validation_tdes.c
@@ -202,7 +202,7 @@  parse_test_tdes_writeback(struct fips_val *val)
 static int
 writeback_tdes_hex_str(const char *key, char *dst, struct fips_val *val)
 {
-	struct fips_val tmp_val;
+	struct fips_val tmp_val = {0};
 
 	tmp_val.len = 8;