diff mbox series

lib: fix write unlock during ring creation

Message ID 1542113714-22607-1-git-send-email-tallurix.chaitanya.babu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series lib: fix write unlock during ring creation |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Chaitanya Babu, TalluriX Nov. 13, 2018, 12:55 p.m. UTC 
  In rte_efd_create() write lock has already been unlocked
before ring creation itself.
So second unlock after the ring creation has been removed
and added freeing of tail queue entry and efd table.

Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
Cc: stable@dpdk.org

Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
---
 lib/librte_efd/rte_efd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Pattan, Reshma Nov. 13, 2018, 4:58 p.m. UTC | #1 
> -----Original Message-----
> From: Chaitanya Babu, TalluriX
> Sent: Tuesday, November 13, 2018 12:55 PM
> To: dev@dpdk.org
> Cc: Marohn, Byron <byron.marohn@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Chaitanya Babu, TalluriX
> <tallurix.chaitanya.babu@intel.com>; stable@dpdk.org
> Subject: [PATCH] lib: fix write unlock during ring creation

Heading should have lib/efd:
> 
> In rte_efd_create() write lock has already been unlocked before ring creation
> itself.
> So second unlock after the ring creation has been removed and added freeing of
> tail queue entry and efd table.

Changes do not have free of  tailq entry, so remove the mention of it from commit message.

> -	/* Create ring (Dummy slot index is not enqueued) */
> +	/*  Create ring (Dummy slot index is not enqueued) */

Undo this change. Unrelated.

Other than these looks ok.

Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Thanks,
Reshma
Thomas Monjalon Nov. 18, 2018, 2:43 p.m. UTC | #2 
13/11/2018 17:58, Pattan, Reshma:
> Heading should have lib/efd:

No, heading should have "efd:"
When in doubts, please look at the git history.
diff mbox series

Patch

diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c
index a780e2fe8..0c7ce9612 100644
--- a/lib/librte_efd/rte_efd.c
+++ b/lib/librte_efd/rte_efd.c
@@ -687,12 +687,13 @@  rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,
 	rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
 
 	snprintf(ring_name, sizeof(ring_name), "HT_%s", table->name);
-	/* Create ring (Dummy slot index is not enqueued) */
+	/*  Create ring (Dummy slot index is not enqueued) */
 	r = rte_ring_create(ring_name, rte_align32pow2(table->max_num_rules),
 			offline_cpu_socket, 0);
 	if (r == NULL) {
 		RTE_LOG(ERR, EFD, "memory allocation failed\n");
-		goto error_unlock_exit;
+		rte_efd_free(table);
+		return NULL;
 	}
 
 	/* Populate free slots ring. Entry zero is reserved for key misses. */