build: establish an invariant machine type
Checks
Commit Message
Add the machine definition 'default' which is special compared
to 'native' (most optimized for current system) or any explicit
type (external entity has to decide on the type).
It defaults to the per arch agreed common minimal baseline
needed for DPDK to reasonable work.
That might not be the most optimized, but the most portable
version while still being able to support the CPU features
required for DPDK.
Going forward this can be bumped up by the DPDK project, but it
can never be an invariant like 'native'.
Distributions and other needing portable code are expected to
define the machine as 'baseline'.
Changes in v2:
- fixed the non 64 bit arm default type
- changed baseline to default to match the old build system
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
config/meson.build | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
Comments
On Wed, Nov 14, 2018 at 02:18:38PM +0100, Christian Ehrhardt wrote:
> Add the machine definition 'default' which is special compared
> to 'native' (most optimized for current system) or any explicit
> type (external entity has to decide on the type).
>
> It defaults to the per arch agreed common minimal baseline
> needed for DPDK to reasonable work.
>
> That might not be the most optimized, but the most portable
> version while still being able to support the CPU features
> required for DPDK.
>
> Going forward this can be bumped up by the DPDK project, but it
> can never be an invariant like 'native'.
>
> Distributions and other needing portable code are expected to
> define the machine as 'baseline'.
>
Need to change 'baseline' to 'default' here.
> Changes in v2:
> - fixed the non 64 bit arm default type
> - changed baseline to default to match the old build system
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
@@ -7,6 +7,27 @@ if meson.is_cross_build()
else
machine = get_option('machine')
endif
+
+# machine type 'default' is special, it defaults to the per arch agreed common
+# minimal baseline needed for DPDK.
+# That might not be the most optimized, but the most portable version while
+# still being able to support the CPU features required for DPDK.
+# This can be bumped up by the DPDK project, but it can never be an
+# invariant like 'native'
+if machine == 'default'
+ if host_machine.cpu_family().startswith('x86')
+ # matches the old pre-meson build systems default
+ machine = 'corei7'
+ elif host_machine.cpu_family().startswith('arm')
+ machine = 'armv7-a'
+ elif host_machine.cpu_family().startswith('aarch')
+ # arm64 manages defaults in config/arm/meson.build
+ machine = 'default'
+ elif host_machine.cpu_family().startswith('ppc')
+ machine = 'power8'
+ endif
+endif
+
dpdk_conf.set('RTE_MACHINE', machine)
machine_args = []