[v4,3/5] doc/guides/tools: add doc files

Message ID 1542983269-30093-4-git-send-email-tomaszx.jozwiak@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series add initial version of compress-perf |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tomasz Jozwiak Nov. 23, 2018, 2:27 p.m. UTC
  Added:
 -  initial version of compression performance test
    description file.
 -  release note in release_18_11.rst

Updated index.rst file

Signed-off-by: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 MAINTAINERS                            |  5 +++
 doc/guides/rel_notes/release_18_11.rst |  5 +++
 doc/guides/tools/comp_perf.rst         | 75 ++++++++++++++++++++++++++++++++++
 doc/guides/tools/index.rst             |  1 +
 4 files changed, 86 insertions(+)
 create mode 100644 doc/guides/tools/comp_perf.rst
  

Comments

Varghese, Vipin Nov. 23, 2018, 3 p.m. UTC | #1
Apologies Tomasz, I shared my comments in v3. sharing for v4

>  Crypto performance test application
>  M: Declan Doherty <declan.doherty@intel.com>
>  F: app/test-crypto-perf/
> diff --git a/doc/guides/rel_notes/release_18_11.rst
> b/doc/guides/rel_notes/release_18_11.rst
> index 32ff0e5..d44cf30 100644
> --- a/doc/guides/rel_notes/release_18_11.rst
> +++ b/doc/guides/rel_notes/release_18_11.rst
> @@ -328,6 +328,11 @@ New Features
>    additional command-line parameter values from the "DPDK_TEST_PARAMS"
>    environment variable to make this application easier to use.
> 
> +* **Added a compression performance test tool.**

It is mentioned as test application above, here test tool. Should we make this synced?

> 
>  API Changes
>  -----------
> diff --git a/doc/guides/tools/comp_perf.rst b/doc/guides/tools/comp_perf.rst
> new file mode 100644 index 0000000..1428348
> --- /dev/null
> +++ b/doc/guides/tools/comp_perf.rst
> @@ -0,0 +1,75 @@
> +..  SPDX-License-Identifier: BSD-3-Clause
> +    Copyright(c) 2018 Intel Corporation.
> +
> +dpdk-test-compress-perf Application
> +===================================

Should we remove extra '='?

> +
> +The ``dpdk-test-compress-perf`` tool is a Data Plane Development Kit
> +(DPDK) utility that allows measuring performance parameters of PMDs

Should we keep this as test application? Or is this an utility like pdump or procinfo?

> +
> +
> +Limitations
> +~~~~~~~~~~~

Extra '~'?

> +
> +* Only supports the fixed compression and stateless operation.

Is 'stateful' not supported a limitation rather than supporting stateless?

> +
> +Command line options
> +--------------------
> +

Missing '-'

> +Compiling the Application
> +-------------------------
> +
> +**Step 1: PMD setting**
> +
> +The ``dpdk-test-compress-perf`` tool depends on compression device
> +drivers PMD which can be disabled by default in the build configuration file
> ``common_base``.
> +The compression device drivers PMD which should be tested can be enabled
> by setting::
> +
> +   CONFIG_RTE_LIBRTE_PMD_ISAL=y

Does this test application other PMD? If not can we cover this in limitation?

> +
> +
> +Running the Application
> +-----------------------
> +
> +The tool application has a number of command line options. Here is the
> sample command line:

Do we need to reword 'tool application' to either 'test application' or 'test utility'?

> +
> +.. code-block:: console
> +
> +   ./build/app/dpdk-test-compress-perf  -l 4 -- --driver-name compress_qat --
> input-file test.txt --seg-sz 8192
> +    --compress-level 1:1:9 --num-iter 10 --extended-input-sz 1048576
> + --max-num-sgl-segs 16 --huffman-enc fixed
> +
> diff --git a/doc/guides/tools/index.rst b/doc/guides/tools/index.rst index
> a6e2c4c..24235ba 100644
> --- a/doc/guides/tools/index.rst
> +++ b/doc/guides/tools/index.rst
> @@ -42,3 +42,4 @@ DPDK Tools User Guides
>      testbbdev
>      cryptoperf
>      testeventdev
> +    comp_perf
> --
> 2.7.4
  
Tomasz Jozwiak Nov. 23, 2018, 3:12 p.m. UTC | #2
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Friday, November 23, 2018 4:00 PM
> To: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; dev@dpdk.org; Trahe,
> Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>; Shally.Verma@cavium.com;
> akhil.goyal@nxp.com
> Subject: RE: [dpdk-dev] [PATCH v4 3/5] doc/guides/tools: add doc files
> 
> Apologies Tomasz, I shared my comments in v3. sharing for v4
> 
> >  Crypto performance test application
> >  M: Declan Doherty <declan.doherty@intel.com>
> >  F: app/test-crypto-perf/
> > diff --git a/doc/guides/rel_notes/release_18_11.rst
> > b/doc/guides/rel_notes/release_18_11.rst
> > index 32ff0e5..d44cf30 100644
> > --- a/doc/guides/rel_notes/release_18_11.rst
> > +++ b/doc/guides/rel_notes/release_18_11.rst
> > @@ -328,6 +328,11 @@ New Features
> >    additional command-line parameter values from the
> "DPDK_TEST_PARAMS"
> >    environment variable to make this application easier to use.
> >
> > +* **Added a compression performance test tool.**
> 
> It is mentioned as test application above, here test tool. Should we make this
> synced?

Will sync

> 
> >
> >  API Changes
> >  -----------
> > diff --git a/doc/guides/tools/comp_perf.rst
> > b/doc/guides/tools/comp_perf.rst new file mode 100644 index
> > 0000000..1428348
> > --- /dev/null
> > +++ b/doc/guides/tools/comp_perf.rst
> > @@ -0,0 +1,75 @@
> > +..  SPDX-License-Identifier: BSD-3-Clause
> > +    Copyright(c) 2018 Intel Corporation.
> > +
> > +dpdk-test-compress-perf Application
> > +===================================
> 
> Should we remove extra '='?

It's ok. Please take a look at console output or count the chars 



> 
> > +
> > +The ``dpdk-test-compress-perf`` tool is a Data Plane Development Kit
> > +(DPDK) utility that allows measuring performance parameters of PMDs
> 
> Should we keep this as test application? Or is this an utility like pdump or
> procinfo?
> 
> > +
> > +
> > +Limitations
> > +~~~~~~~~~~~
> 
> Extra '~'?

No. It's ok. Please take a look at console output or count the chars


> 
> > +
> > +* Only supports the fixed compression and stateless operation.
> 
> Is 'stateful' not supported a limitation rather than supporting stateless?

In this initial version we support only stateless operation. Will be updated in the future versions.


> 
> > +
> > +Command line options
> > +--------------------
> > +
> 
> Missing '-'

No. It's ok. Please take a look at console output or count the chars

> 
> > +Compiling the Application
> > +-------------------------
> > +
> > +**Step 1: PMD setting**
> > +
> > +The ``dpdk-test-compress-perf`` tool depends on compression device
> > +drivers PMD which can be disabled by default in the build
> > +configuration file
> > ``common_base``.
> > +The compression device drivers PMD which should be tested can be
> > +enabled
> > by setting::
> > +
> > +   CONFIG_RTE_LIBRTE_PMD_ISAL=y
> 
> Does this test application other PMD? If not can we cover this in limitation?

Should be eg.:


> 
> > +
> > +
> > +Running the Application
> > +-----------------------
> > +
> > +The tool application has a number of command line options. Here is
> > +the
> > sample command line:
> 
> Do we need to reword 'tool application' to either 'test application' or 'test
> utility'?

Will sync this.

> 
> > +
> > +.. code-block:: console
> > +
> > +   ./build/app/dpdk-test-compress-perf  -l 4 -- --driver-name
> > + compress_qat --
> > input-file test.txt --seg-sz 8192
> > +    --compress-level 1:1:9 --num-iter 10 --extended-input-sz 1048576
> > + --max-num-sgl-segs 16 --huffman-enc fixed
> > +
> > diff --git a/doc/guides/tools/index.rst b/doc/guides/tools/index.rst
> > index a6e2c4c..24235ba 100644
> > --- a/doc/guides/tools/index.rst
> > +++ b/doc/guides/tools/index.rst
> > @@ -42,3 +42,4 @@ DPDK Tools User Guides
> >      testbbdev
> >      cryptoperf
> >      testeventdev
> > +    comp_perf
> > --
> > 2.7.4




Thx, Tomek
  
Varghese, Vipin Nov. 23, 2018, 3:26 p.m. UTC | #3
Thank you for the update
  

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 71ba312..dd0c131 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1242,6 +1242,11 @@  M: Bernard Iremonger <bernard.iremonger@intel.com>
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/
 
+Compression performance test application
+M: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
+F: app/test-compress-perf/
+F: doc/guides/tools/comp_perf.rst
+
 Crypto performance test application
 M: Declan Doherty <declan.doherty@intel.com>
 F: app/test-crypto-perf/
diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index 32ff0e5..d44cf30 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -328,6 +328,11 @@  New Features
   additional command-line parameter values from the "DPDK_TEST_PARAMS"
   environment variable to make this application easier to use.
 
+* **Added a compression performance test tool.**
+
+   Added a new performance test tool to test the compressdev PMD. The tool tests
+   compression ratio and compression throughput. Dynamic compression test is not
+   supported yet.
 
 API Changes
 -----------
diff --git a/doc/guides/tools/comp_perf.rst b/doc/guides/tools/comp_perf.rst
new file mode 100644
index 0000000..1428348
--- /dev/null
+++ b/doc/guides/tools/comp_perf.rst
@@ -0,0 +1,75 @@ 
+..  SPDX-License-Identifier: BSD-3-Clause
+    Copyright(c) 2018 Intel Corporation.
+
+dpdk-test-compress-perf Application
+===================================
+
+The ``dpdk-test-compress-perf`` tool is a Data Plane Development Kit (DPDK)
+utility that allows measuring performance parameters of PMDs available in the
+compress tree. The application reads the data from a file (--input-file),
+dumps all the file into a buffer and fills out the data of input mbufs,
+which are passed to compress device with compression operations.
+Then, the output buffers are fed into the decompression stage, and the resulting
+data is compared against the original data (verification phase). After that,
+a number of iterations are performed, compressing first and decompressing later,
+to check the throughput rate
+(showing cycles/iteration, cycles/Byte and Gbps, for compression and decompression).
+
+
+Limitations
+~~~~~~~~~~~
+
+* Only supports the fixed compression and stateless operation.
+
+Command line options
+--------------------
+
+ ``--driver-name NAME``: compress driver to use
+
+ ``--input-file NAME``: file to compress and decompress
+
+ ``--extended-input-sz N``: extend file data up to this size (default: no extension)
+
+ ``--seg-sz N``: size of segment to store the data (default: 2048)
+
+ ``--burst-sz N``: compress operation burst size
+
+ ``--pool-sz N``: mempool size for compress operations/mbufs (default: 8192)
+
+ ``--max-num-sgl-segs N``: maximum number of segments for each mbuf (default: 16)
+
+ ``--num-iter N``: number of times the file will be compressed/decompressed (default: 10000)
+
+ ``--operation [comp/decomp/comp_and_decomp]``: perform test on compression, decompression or both operations
+
+ ``--huffman-enc [fixed/default]``: Huffman encoding (default: fixed)
+
+ ``--compress-level N``: compression level, which could be a single value, list or range (default: range between 1 and 9)
+
+ ``--window-sz N``: base two log value of compression window size (default: max supported by PMD)
+
+ ``-h``: prints this help
+
+
+Compiling the Application
+-------------------------
+
+**Step 1: PMD setting**
+
+The ``dpdk-test-compress-perf`` tool depends on compression device drivers PMD which
+can be disabled by default in the build configuration file ``common_base``.
+The compression device drivers PMD which should be tested can be enabled by setting::
+
+   CONFIG_RTE_LIBRTE_PMD_ISAL=y
+
+
+Running the Application
+-----------------------
+
+The tool application has a number of command line options. Here is the sample command line:
+
+.. code-block:: console
+
+   ./build/app/dpdk-test-compress-perf  -l 4 -- --driver-name compress_qat --input-file test.txt --seg-sz 8192
+    --compress-level 1:1:9 --num-iter 10 --extended-input-sz 1048576  --max-num-sgl-segs 16 --huffman-enc fixed
+
diff --git a/doc/guides/tools/index.rst b/doc/guides/tools/index.rst
index a6e2c4c..24235ba 100644
--- a/doc/guides/tools/index.rst
+++ b/doc/guides/tools/index.rst
@@ -42,3 +42,4 @@  DPDK Tools User Guides
     testbbdev
     cryptoperf
     testeventdev
+    comp_perf