crypto/aesni_mb: fix missed wrapping

Message ID 20181218140356.69185-1-roy.fan.zhang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series crypto/aesni_mb: fix missed wrapping |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Fan Zhang Dec. 18, 2018, 2:03 p.m. UTC
  This patch fixes the missed macro check of intel-ipsec-mb version.
Since plain SHA is supported only in 0.52, without a marco to
wrap the newly introduced definitions will cause the failed
compile if intel-ipsec-mb older than 0.52 is installed.

Fixes: 9d8dd0c5af95 ("crypto/aesni_mb: support plain sha")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Akhil Goyal Dec. 18, 2018, 3:18 p.m. UTC | #1
On 12/18/2018 7:33 PM, Fan Zhang wrote:
> This patch fixes the missed macro check of intel-ipsec-mb version.
> Since plain SHA is supported only in 0.52, without a marco to
> wrap the newly introduced definitions will cause the failed
> compile if intel-ipsec-mb older than 0.52 is installed.
>
> Fixes: 9d8dd0c5af95 ("crypto/aesni_mb: support plain sha")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>
merged with original commit on dpdk-next-crypto
  

Patch

diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
index 6f4f5eeea..781d3ea31 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
@@ -109,11 +109,13 @@  static const unsigned auth_digest_byte_lengths[] = {
 		[AES_CMAC]	= 16,
 		[AES_GMAC]	= 12,
 		[NULL_HASH]	= 0,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
 		[PLAIN_SHA1] 	= 20,
 		[PLAIN_SHA_224] = 28,
 		[PLAIN_SHA_256] = 32,
 		[PLAIN_SHA_384] = 48,
 		[PLAIN_SHA_512] = 64
+#endif
 	/**< Vector mode dependent pointer table of the multi-buffer APIs */
 
 };