[v2] devtools: fix wrong headline lowercase for arm

Message ID 20181220161045.9487-1-gavin.hu@arm.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] devtools: fix wrong headline lowercase for arm |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Gavin Hu Dec. 20, 2018, 4:10 p.m. UTC
  Change to the new wording according to Arm corp:
https://mails.dpdk.org/archives/dev/2018-October/115174.html
otherwise, "Wrong headline lowercase" may be falsely reported.

Fixes: f146ada21d1e ("scripts: add more git log checks")
Cc: stable@dpdk.org

Signed-off-by: Gavin Hu <gavin.hu@arm.com>
---
 devtools/check-git-log.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Honnappa Nagarahalli Dec. 20, 2018, 8:50 p.m. UTC | #1
> 
> Change to the new wording according to Arm corp:
> https://mails.dpdk.org/archives/dev/2018-October/115174.html
> otherwise, "Wrong headline lowercase" may be falsely reported.
> 
> Fixes: f146ada21d1e ("scripts: add more git log checks")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> ---
>  devtools/check-git-log.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index
> 85d67fb9a..15f15e18b 100755
> --- a/devtools/check-git-log.sh
> +++ b/devtools/check-git-log.sh
> @@ -90,9 +90,9 @@ bad=$(echo "$headlines" | grep -E --color=always \
>  	-e ':.*\<[hsf]w\>' \
>  	-e ':.*\<l[234]\>' \
>  	-e ':.*\<api\>' \
> -	-e ':.*\<arm\>' \
> -	-e ':.*\<armv7\>' \
> -	-e ':.*\<armv8\>' \
> +	-e ':.*\<ARM\>' \
> +	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
> +	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \
Can you add aarch64/aarch32/arm64/arm32 related permutations?

>  	-e ':.*\<crc\>' \
>  	-e ':.*\<dma\>' \
>  	-e ':.*\<eeprom\>' \
> --
> 2.11.0
  

Patch

diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 85d67fb9a..15f15e18b 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -90,9 +90,9 @@  bad=$(echo "$headlines" | grep -E --color=always \
 	-e ':.*\<[hsf]w\>' \
 	-e ':.*\<l[234]\>' \
 	-e ':.*\<api\>' \
-	-e ':.*\<arm\>' \
-	-e ':.*\<armv7\>' \
-	-e ':.*\<armv8\>' \
+	-e ':.*\<ARM\>' \
+	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
+	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \
 	-e ':.*\<crc\>' \
 	-e ':.*\<dma\>' \
 	-e ':.*\<eeprom\>' \