compress/qat: add compression on dh895x

Message ID 1545383722-13294-1-git-send-email-tomaszx.jozwiak@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series compress/qat: add compression on dh895x |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Tomasz Jozwiak Dec. 21, 2018, 9:15 a.m. UTC
  This patch enables compression on dh895x HW series
and updates supported hardware accelerator devices list.

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 doc/guides/compressdevs/qat_comp.rst | 1 +
 drivers/compress/qat/qat_comp.c      | 2 +-
 drivers/compress/qat/qat_comp_pmd.c  | 4 ----
 3 files changed, 2 insertions(+), 5 deletions(-)
  

Comments

Fiona Trahe Dec. 21, 2018, 5:11 p.m. UTC | #1
> -----Original Message-----
> From: Jozwiak, TomaszX
> Sent: Friday, December 21, 2018 2:15 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] compress/qat: add compression on dh895x
> 
> This patch enables compression on dh895x HW series
> and updates supported hardware accelerator devices list.
> 
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
  
De Lara Guarch, Pablo Jan. 9, 2019, 10:40 p.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Trahe, Fiona
> Sent: Friday, December 21, 2018 5:12 PM
> To: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] compress/qat: add compression on dh895x
> 
> 
> 
> > -----Original Message-----
> > From: Jozwiak, TomaszX
> > Sent: Friday, December 21, 2018 2:15 AM
> > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak,
> > TomaszX <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com
> > Subject: [PATCH] compress/qat: add compression on dh895x
> >
> > This patch enables compression on dh895x HW series and updates
> > supported hardware accelerator devices list.
> >
> > Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto.

Thanks,
Pablo
  

Patch

diff --git a/doc/guides/compressdevs/qat_comp.rst b/doc/guides/compressdevs/qat_comp.rst
index aee3b99..1c24ebb 100644
--- a/doc/guides/compressdevs/qat_comp.rst
+++ b/doc/guides/compressdevs/qat_comp.rst
@@ -9,6 +9,7 @@  support for the following hardware accelerator devices:
 
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology dh895x``
 
 
 Features
diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c
index bb00610..e745d13 100644
--- a/drivers/compress/qat/qat_comp.c
+++ b/drivers/compress/qat/qat_comp.c
@@ -270,7 +270,7 @@  static int qat_comp_create_templates(struct qat_comp_xform *qat_xform,
 	    ICP_QAT_FW_COMP_NOT_AUTO_SELECT_BEST,
 	    ICP_QAT_FW_COMP_NOT_ENH_AUTO_SELECT_BEST,
 	    ICP_QAT_FW_COMP_NOT_DISABLE_TYPE0_ENH_AUTO_SELECT_BEST,
-	    ICP_QAT_FW_COMP_DISABLE_SECURE_RAM_USED_AS_INTMD_BUF);
+	    ICP_QAT_FW_COMP_ENABLE_SECURE_RAM_USED_AS_INTMD_BUF);
 
 	comp_req->cd_pars.sl.comp_slice_cfg_word[0] =
 	    ICP_QAT_HW_COMPRESSION_CONFIG_BUILD(
diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c
index ea93077..27c8856 100644
--- a/drivers/compress/qat/qat_comp_pmd.c
+++ b/drivers/compress/qat/qat_comp_pmd.c
@@ -484,10 +484,6 @@  static const struct rte_driver compdev_qat_driver = {
 int
 qat_comp_dev_create(struct qat_pci_device *qat_pci_dev)
 {
-	if (qat_pci_dev->qat_dev_gen == QAT_GEN1) {
-		QAT_LOG(ERR, "Compression PMD not supported on QAT dh895xcc");
-		return 0;
-	}
 	if (qat_pci_dev->qat_dev_gen == QAT_GEN3) {
 		QAT_LOG(ERR, "Compression PMD not supported on QAT c4xxx");
 		return 0;